1273927 - "Learn more" button button is not fully displayed on screen smaller than 4 inch

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Attachment: Screenshot of the issue

Build afdbc70
Device IPhone SE (9.3.1)

Steps to reproduce:
1. Open a new private browsing session
2. Change device orientation to landscape

Actual results:
- The 'Learn more' button is not fully displayed

Expected:
- The button should be fully displayed.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1858

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8757015 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1858

Does the menu bar push the layout up from the bottom, or does it overlap it? If the former, I think a better fix for this would be to pin the Learn More link bottom to be >= the bottom of the view so it gets shifted up with the menu. If the latter, I wonder if it'd be worth changing.

WFM as a band-aid for now.

Comment 3

[Stephan Leroux [:sleroux]]

> Does the menu bar push the layout up from the bottom, or does it overlap it?

The empty view was being added on top of the collection view with it's constraints setup to match the root view's top/left/right/bottom with an offset to factor in the toolbar. Ideally the bottom constraint should be pinned to the top of the toolbar instead of a constant value offset so I've updated that.

> I think a better fix for this would be to pin the Learn More link bottom to be >= the bottom of the view so it gets shifted up with the menu.

I've updated the constraints of the 'Learn More' button to be more adaptive. While in portrait, visually there is no difference to what it was before. In landscape, the learn more button will move up with the menu bar while maintaining a padding of 10px at the bottom.

Comment 4

[Stephan Leroux [:sleroux]]

master 260cadc1e2b87a281831172ed9e908df1d694754

Comment 5

[Simon Basca [:SimonB]]

The 'Learn more' button is displayed correct on master 5979d61c.