Closed
Bug 1273956
Opened 9 years ago
Closed 9 years ago
review state / header text area kludge doesn't always work
Categories
(MozReview Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glob, Assigned: glob)
References
Details
Attachments
(1 file)
the review state / header text area kludge doesn't always work (works for mdoglio, not for me). it appears to be a timing issue.
There's a timing issue with the "show the header editor" hack that happens when
you change the review state. Compound the hack further by deferring its
execution with setTimeout abuse.
Review commit: https://reviewboard.mozilla.org/r/53570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53570/
Attachment #8753925 -
Flags: review?(smacleod)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8753925 [details]
MozReview Request: mozreview: ensure showing the header after review state changes happens last (bug 1273956); r?smacleod
https://reviewboard.mozilla.org/r/53570/#review50322
Hopefully we can still sleep at night.
Attachment #8753925 -
Flags: review?(smacleod) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•