Only enable telemetry logging on non-release builds

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Requested by Finkle on irc – it'd provide better performance and we can log extras on nightly builds.

Useful context:
14:26 <mcomella> mfinkle: re telemetry extras logging (from earlier in the day) – I'm afraid features in the future will add extras logging without considering the privacy considerations. Are we okay risking the privacy of our users on nightly builds?
14:29 <@mfinkle> mcomella: i would say yes
14:29 <@margaret> mcomella: anything we log in an extra we're also uploading to our severs
14:29 <@mfinkle> mcomella: you have a false sense of security by "plugging" a single hole
14:30 <@mfinkle> i bet we are still logging URLs, if you look hard enough
14:32 <mcomella> Fair enough

Bonus comment:
14:32 <mcomella> (if we have the cycles) sounds like a larger mission should be to use a logger we can shut on/off at the user's discretion
Created attachment 8754106 [details]
MozReview Request: Bug 1274051 - Only log telemetry in release builds. r=grisha

Review commit: https://reviewboard.mozilla.org/r/53728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53728/
Attachment #8754106 - Flags: review?(gkruglov)

Comment 2

2 years ago
Comment on attachment 8754106 [details]
MozReview Request: Bug 1274051 - Only log telemetry in release builds. r=grisha

https://reviewboard.mozilla.org/r/53728/#review50552

The code is doing what you want (only logs telemtry in non-release builds), but the commit comment is the exact opposite :-)
Attachment #8754106 - Flags: review?(gkruglov) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/26baaed13801
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.