Closed Bug 1274052 Opened 8 years ago Closed 8 years ago

Log search engine identifier as an extra

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

Originally implemented without an extra in bug 1261617, Finkle suggested adding it with "other" as the identifier for custom search engines to avoid displaying user data.
recordSearch currently captures `engine.getEngineIdentifier()` [1] which has the following algorithm:

        if (this.identifier != null) {
            return this.identifier;
        }
        if (this.name != null) {
            return "other-" + this.name;
        }
        return "other";

If we wanted to keep this simple, we could send the same data for both UI telemetry and core ping telemetry (is there any value in sending the search engine name for custom search engines?):

(engine.identifier == null) ? "other" : engine.identifier

[1]: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#3899
[2]: https://dxr.mozilla.org/mozilla-central/rev/f3f2fa1d7eed5a8262f6401ef18ff8117a3ce43e/mobile/android/base/java/org/mozilla/gecko/home/SearchEngine.java#68
I'm going to assume there is no value in sending the search engine name with .getEngineIdentifier – users who add custom search engines are going to be in the minority (I think!) and the chances of them adding the same search engines are small (besides, the pages can change their title which would categorize these as two separate search engines when they're really the same).
Comment on attachment 8754087 [details]
MozReview Request: Bug 1274052 - Log search engine identifier as extra. r=grisha

https://reviewboard.mozilla.org/r/53716/#review50548

lgtm
Attachment #8754087 - Flags: review?(gkruglov) → review+
https://hg.mozilla.org/mozilla-central/rev/ec195d45c4d8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: