1274113 - Add a non-component manager way to get a timer

Status: NEW

(Core :: XPCOM, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Using do_CreateInstance for this is silly.

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8754168 [details] [diff] [review]
Patch

Review of attachment 8754168 [details] [diff] [review]:
-----------------------------------------------------------------

I have virtually this exact patch in my own tree and it fails miserably in tests, because some code implicitly relies on timer instances not being created after shutdown (!), and removing |rv| and null checks causes this to fall over.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Ok ... that's awful.  But I still need this in this case, so lets cut it back to the basics.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8754548 [details] [diff] [review]
Patch

Review of attachment 8754548 [details] [diff] [review]:
-----------------------------------------------------------------

This is still footgunny.  I agree that it's just stupid to go through XPCOM like this, but a non-XPCOM solution needs to be as safe as the XPCOM solution.  What do you really need this for?

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I wanted it to be able to use timers without initializing XPCOM, which is one of the few bits of chromium support code the plugin process uses.