Add a non-component manager way to get a timer

NEW
Unassigned

Status

()

2 years ago
2 years ago

People

(Reporter: khuey, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8754168 [details] [diff] [review]
Patch

Using do_CreateInstance for this is silly.
Attachment #8754168 - Flags: review?(nfroyd)
Comment on attachment 8754168 [details] [diff] [review]
Patch

Review of attachment 8754168 [details] [diff] [review]:
-----------------------------------------------------------------

I have virtually this exact patch in my own tree and it fails miserably in tests, because some code implicitly relies on timer instances not being created after shutdown (!), and removing |rv| and null checks causes this to fall over.
Attachment #8754168 - Flags: review?(nfroyd) → review-
Created attachment 8754548 [details] [diff] [review]
Patch

Ok ... that's awful.  But I still need this in this case, so lets cut it back to the basics.
Attachment #8754168 - Attachment is obsolete: true
Attachment #8754548 - Flags: review?(nfroyd)
Comment on attachment 8754548 [details] [diff] [review]
Patch

Review of attachment 8754548 [details] [diff] [review]:
-----------------------------------------------------------------

This is still footgunny.  I agree that it's just stupid to go through XPCOM like this, but a non-XPCOM solution needs to be as safe as the XPCOM solution.  What do you really need this for?
Attachment #8754548 - Flags: review?(nfroyd)
I wanted it to be able to use timers without initializing XPCOM, which is one of the few bits of chromium support code the plugin process uses.
Assignee: khuey → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.