Closed Bug 1274148 Opened 4 years ago Closed 4 years ago

Use MOZ_MUST_USE more in xpcom/io/

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- affected
firefox50 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

xpcom/io/ is up next for MOZ_MUST_USE-ification.
erahm, please review the xpcom/ changes.

bagder, please review the netwerk/ change. I wasn't sure if aborting on failure
was the best approach here.

mattwoodrow, please review the gfx/ change.
Attachment #8754213 - Flags: review?(matt.woodrow)
Attachment #8754213 - Flags: review?(erahm)
Attachment #8754213 - Flags: review?(daniel)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Attachment #8754213 - Flags: review?(matt.woodrow) → review+
Attachment #8754213 - Flags: review?(daniel) → review+
The netwerk failure seems appropriate to me, and should anyhow be extremely rare...
Attachment #8754213 - Flags: review?(erahm) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed86240bc7725cddfd351b22584bf4a2197d22b
Bug 1274148 (part 1) - Use MOZ_MUST_USE more in xpcom/io/Base64.h. r=erahm,bagder,mattwoodrow.
Attachment #8754213 - Flags: checkin+
https://hg.mozilla.org/integration/mozilla-inbound/rev/436e32fd45174bdb19dbd79fc2eb46b66650513e
Bug 1274148 (part 1, attempt 2) - Use MOZ_MUST_USE more in xpcom/io/Base64.h. r=erahm,bagder,mattwoodrow.
https://hg.mozilla.org/mozilla-central/rev/436e32fd4517
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.