Closed
Bug 1274170
Opened 8 years ago
Closed 8 years ago
Remove unnecessary includes of nsCorsListenerProxy
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
(Blocks 1 open bug)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
4.94 KB,
patch
|
jkt
:
review+
|
Details | Diff | Splinter Review |
After centralizing the CORS initialization within nsContentSecurityManager, we should remove all unnecessary includes of nsCORSListenerProxy [1] [1] http://mxr.mozilla.org/mozilla-central/search?string=nsCorsListenerProxy
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-backlog] → [domsecurity-active]
Assignee | ||
Comment 1•8 years ago
|
||
Jonathan, when converting callsites to use channel->AsyncOpen2() we also centralized CORS within the contentSecurityManager but apparently we never removed the #includes for nsCorsListenerProxy from those callsites.
Attachment #8763838 -
Flags: review?(jkingston)
Comment 2•8 years ago
|
||
Comment on attachment 8763838 [details] [diff] [review] bug_1274170_remove_unecessary_includes_nscorslistenerproxy.patch Review of attachment 8763838 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, checked files for interfaces used and couldn't see any.
Attachment #8763838 -
Flags: review?(jkingston) → review+
Comment 3•8 years ago
|
||
And browser seems to work which I guess is more important :)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8177f507952c Remove unnecessary includes of nsCorsListenerProxy. r=jkingston
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8177f507952c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•