1274216 - Remove use of FlushableTaskQueue from PlatformDecoderModule

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=543ec9f845a7

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1274216 - remove use of FlushableTaskQueue from PlatformDecoderModule. r=jya.

Review commit: https://reviewboard.mozilla.org/r/55020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55020/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8756202 [details]
MozReview Request: Bug 1274216 - remove use of FlushableTaskQueue from PlatformDecoderModule. r=jya.

https://reviewboard.mozilla.org/r/55020/#review51692

::: dom/media/platforms/PlatformDecoderModule.h:92
(Diff revision 1)
>    // This is called on the decode task queue.
>    virtual already_AddRefed<MediaDataDecoder>
>    CreateVideoDecoder(const VideoInfo& aConfig,
>                       layers::LayersBackend aLayersBackend,
>                       layers::ImageContainer* aImageContainer,
> -                     FlushableTaskQueue* aVideoTaskQueue,
> +                     TaskQueue* aTaskQueue,

I feel that the renaming of the parameter is out of scope of this change, but up to you..

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b615a565d65

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5b615a565d65