1274228 - Crash when import a settings from Becky!2

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[baffclan]

Steps to Reproduce:
1. Tools -> Import
2. appear Import dialog
3. select Settings and click [Next>]
4. select Becky! Internet Mail and click [Next>]
5. Appear explorer
6. Goto MailBox Folder
7. select mailbox.ini, and click [Open]
8. Crash

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:49.0) Gecko/20100101 Thunderbird/49.0a1
Build ID: 20160517030214

https://crash-stats.mozilla.com/report/index/cd5b70b7-e234-4d82-9b65-026252160519
https://crash-stats.mozilla.com/report/index/2f241c69-f58c-4b27-b3ee-f45e02160519

Comment 1

[Kent James (:rkent)]

Crash code:


279   nsCOMPtr<nsIConverterInputStream> convertedInput;
280   convertedInput->Init(source, nsMsgI18NFileSystemCharset(), kBlock, 0x0000);
281 

That's obviously incorrect.

Comment 2

[:aceman]

This is probably my work. This function was modified by me to accommodate Neil's comments. 

Looks like it should be
nsCOMPtr<nsIConverterInputStream> convertedInput =
   do_CreateInstance("@mozilla.org/intl/converter-input-stream;1");

Similarly with the output stream.

Comment 3

[:aceman]

Hi, please try the build from here if it still crashes:
http://mzl.la/1s6Etbq

Comment 4

[baffclan]

Thanks for make a try-builds.

No Crashed, and Can imports Settings.

Comment 5

[:aceman]

(In reply to baffclan from comment #4)
> No Crashed, and Can imports Settings.

Thanks, can you say from quick glance that the settings seem to be imported correctly?

Comment 6

[baffclan]

I think that could be imported without any problems.
(however, I do not testing a send/receive.)

Comment 7

[:aceman]

Attachment: patch

Great, thanks for checking.

Comment 8

[Kent James (:rkent)]

Comment on attachment 8756906 [details] [diff] [review]
patch

Thanks for working on this!

Comment 9

[:aceman]

https://hg.mozilla.org/comm-central/rev/227af1b2b71d7cdbfd08e6753d13225fc502ae38