1274333 - [ESLint] Clean up indentation errors after auto fix

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The auto fix in bug 1271084 messed up indentation in a few files.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1274333 - Fix indentation of Heritage.extend. r=tromey

ESLint's auto-fix got confused by cases that passed an object literal to
Heritage.extend() but placed the opening brace on the next line.

Review commit: https://reviewboard.mozilla.org/r/53988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53988/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4280c9e04762

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8754474 [details]
MozReview Request: Bug 1274333 - Fix indentation of Heritage.extend. r=tromey

https://reviewboard.mozilla.org/r/53988/#review50712

Thank you for cleaning this up.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try run looks good enough if you subtract the Windows intermittents that are everywhere these days...

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing against fx-team tip.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2a2aff773bcb

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a2aff773bcb