1274417 - Notification with non-cached icon does not show

Status: RESOLVED DUPLICATE of bug 1215861

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Eitan Isaacson [:eeejay]]

Attachment: Test case

When a new notification is created with an icon, it is not shown. Subsequent notifications when the icon is already cached show.

Comment 1

[Eitan Isaacson [:eeejay]]

This is with linux/libnotify..

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. r?karlt

Review commit: https://reviewboard.mozilla.org/r/54048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54048/

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 8754559 [details]
MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. r?karlt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54048/diff/1-2/

Comment 4

[Matthew N. [:MattN]]

This is a dupe of bug 1215861 which I think will get addressed by bug 1233086. I don't think synchronous decoding was wanted.

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8754559 [details]
MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. r?karlt

https://reviewboard.mozilla.org/r/54048/#review50784

::: toolkit/system/gnome/nsAlertsIconListener.cpp:158
(Diff revision 2)
>  
>    // Ask the image to decode at its intrinsic size.
>    int32_t width = 0, height = 0;
>    image->GetWidth(&width);
>    image->GetHeight(&height);
> -  image->RequestDecodeForSize(nsIntSize(width, height), imgIContainer::FLAG_NONE);
> +  image->RequestDecodeForSize(nsIntSize(width, height), imgIContainer::FLAG_SYNC_DECODE);

Why is a sync decode required?
The result is not used during this function.

If there is a good reason for this, then please request review from :seth.  He knows the decode API.

Comment 6

[Karl Tomlinson (:karlt)]

Is this the same bug as bug 1215861 and bug 1233086?

Does addressing https://bugzilla.mozilla.org/show_bug.cgi?id=1233086#c14 fix this?