Notification with non-cached icon does not show

RESOLVED DUPLICATE of bug 1215861

Status

()

Toolkit
Notifications and Alerts
RESOLVED DUPLICATE of bug 1215861
2 years ago
2 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8754557 [details]
Test case

When a new notification is created with an icon, it is not shown. Subsequent notifications when the icon is already cached show.
(Assignee)

Comment 1

2 years ago
This is with linux/libnotify..
(Assignee)

Comment 2

2 years ago
Created attachment 8754559 [details]
MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. r?karlt

Review commit: https://reviewboard.mozilla.org/r/54048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54048/
(Assignee)

Comment 3

2 years ago
Comment on attachment 8754559 [details]
MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. r?karlt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54048/diff/1-2/
Attachment #8754559 - Attachment description: MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. → MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. r?karlt
Attachment #8754559 - Flags: review?(karlt)
(Assignee)

Updated

2 years ago
Assignee: nobody → eitan
This is a dupe of bug 1215861 which I think will get addressed by bug 1233086. I don't think synchronous decoding was wanted.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1215861
Comment on attachment 8754559 [details]
MozReview Request: Bug 1274417 - Decode icon for libnotify synchronously. r?karlt

https://reviewboard.mozilla.org/r/54048/#review50784

::: toolkit/system/gnome/nsAlertsIconListener.cpp:158
(Diff revision 2)
>  
>    // Ask the image to decode at its intrinsic size.
>    int32_t width = 0, height = 0;
>    image->GetWidth(&width);
>    image->GetHeight(&height);
> -  image->RequestDecodeForSize(nsIntSize(width, height), imgIContainer::FLAG_NONE);
> +  image->RequestDecodeForSize(nsIntSize(width, height), imgIContainer::FLAG_SYNC_DECODE);

Why is a sync decode required?
The result is not used during this function.

If there is a good reason for this, then please request review from :seth.  He knows the decode API.
Attachment #8754559 - Flags: review?(karlt)
Is this the same bug as bug 1215861 and bug 1233086?

Does addressing https://bugzilla.mozilla.org/show_bug.cgi?id=1233086#c14 fix this?
You need to log in before you can comment on or make changes to this bug.