Closed Bug 1274503 Opened 4 years ago Closed 3 years ago

[UI Events-key] Map some keys on Android with new keys defined by the latest draft

Categories

(Core :: Widget: Android, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox49 --- affected
firefox53 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug, )

Details

Attachments

(5 files)

The latest draft defines a lot of keys for Android specific keys. We should map them.
Status: NEW → ASSIGNED
Comment on attachment 8816118 [details]
Bug 1274503 part.0 Move "MediaFastForward" to "Media Keys" section for keeping same order with the spec

https://reviewboard.mozilla.org/r/96910/#review97280
Attachment #8816118 - Flags: review?(bugs) → review+
Comment on attachment 8816119 [details]
Bug 1274503 part.1 AKEYCODE_ASSIST shouldn't be mapped to "Help"

https://reviewboard.mozilla.org/r/96912/#review97282
Attachment #8816119 - Flags: review?(bugs) → review+
Comment on attachment 8816120 [details]
Bug 1274503 part.2 Add KeyboardEvent.key value mapping on Android which are not mapped by Gecko but mapped on Chromium

https://reviewboard.mozilla.org/r/96914/#review97284
Attachment #8816120 - Flags: review?(bugs) → review+
Comment on attachment 8816121 [details]
Bug 1274503 part.3 Remap AKEYCODE_BACK, AKEYCODE_DPAD_CENTER and AKEYCODE_CAPTIONS to same KeyboardEvent.key value as Chromium

https://reviewboard.mozilla.org/r/96916/#review97286

In general feels bad to keep changing this stuff, but given that Chrome has this, fine.
Attachment #8816121 - Flags: review?(bugs) → review+
Comment on attachment 8816122 [details]
Bug 1274503 part.4 Remove some odd whitespaces in NativeKeyToDOMKeyName.h

https://reviewboard.mozilla.org/r/96918/#review97288
Attachment #8816122 - Flags: review?(bugs) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/46b896e481eb
part.0 Move "MediaFastForward" to "Media Keys" section for keeping same order with the spec r=smaug
https://hg.mozilla.org/integration/autoland/rev/bdc033e3624b
part.1 AKEYCODE_ASSIST shouldn't be mapped to "Help" r=smaug
https://hg.mozilla.org/integration/autoland/rev/9b70d74e63f8
part.2 Add KeyboardEvent.key value mapping on Android which are not mapped by Gecko but mapped on Chromium r=smaug
https://hg.mozilla.org/integration/autoland/rev/0d4d808dee27
part.3 Remap AKEYCODE_BACK, AKEYCODE_DPAD_CENTER and AKEYCODE_CAPTIONS to same KeyboardEvent.key value as Chromium r=smaug
https://hg.mozilla.org/integration/autoland/rev/6c0fb6a93e90
part.4 Remove some odd whitespaces in NativeKeyToDOMKeyName.h r=smaug
You need to log in before you can comment on or make changes to this bug.