1274517 - Remove DefaultBrowserOptOut code after the stub installer and installer no longer support setting Firefox as the default browser

Status: NEW

(Firefox :: Shell Integration, defect, P3)

Description

[Robert Strong (they/them - no direct email)]

The ability to set Firefox as the default browser is being removed in bug 1272162 so this code should no longer be necessary.

http://mxr.mozilla.org/mozilla-central/source/browser/components/shell/ShellService.jsm#63

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Note: ShellService.jsm has Windows newlines. To simplify the review the patch won't have the newlines fixed but I'll submit a separate patch with them fixed.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 with fixed newlines

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8754706 [details] [diff] [review]
patch rev1

The installer will no longer set as default browser when bug 1272162 so this code is no longer necessary.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8754706 [details] [diff] [review]
patch rev1

Review of attachment 8754706 [details] [diff] [review]:
-----------------------------------------------------------------

Due to bug 1238833, you could submit the patch with line-ending changes to mozreview and the review would still be readable.