Closed
Bug 1274531
Opened 8 years ago
Closed 8 years ago
git-mozreview file path error on Windows
Categories
(MozReview Graveyard :: Integration: Git, defect)
MozReview Graveyard
Integration: Git
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: daoshengmu, Assigned: xeonchen)
Details
Attachments
(1 file)
https://github.com/mozilla/version-control-tools/blob/master/git/commands/git-mozreview#L658 On Windows, we need to use 'slash symbol' instead of 'escape symbol' for file paths.
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → xeonchen
|
Assignee | |
Comment 1•8 years ago
|
||
This can be simply reproduced by following python script:
> re.sub('', 'C:\\git-mozreview', '')
because '\g' is meaningful in re.|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54232/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54232/
Attachment #8754761 -
Flags: review?(gps)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8754761 [details] MozReview Request: Bug 1274531 - replace backslashes in path to slashes; r?gps Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54232/diff/1-2/
|
||
Updated•8 years ago
|
Component: General → Integration: Git
|
|
||
Updated•8 years ago
|
Attachment #8754761 -
Flags: review?(gps) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8754761 [details] MozReview Request: Bug 1274531 - replace backslashes in path to slashes; r?gps https://reviewboard.mozilla.org/r/54232/#review51052
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a595577550d4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•