1274542 - Open new tab via context menu is no longer working as expected

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Catalin Suciu [:csuciu]]

master dff28156
iPad Pro 12.9" (9.3.1)
iPhone 6 Plus (9.3.1)

1. Visit a page that contains links (e.g. bbc.com)
2. Long press on several links and select 'Open In New Tab' from the context menu
3. Long press on several links and select 'Open In New Private Tab' from the context menu
4. Open tabs tray and check if all requested tabs, normal and private, were open 

Result: Not all requested tabs are open. In some cases, as you can see in the video, no new tab is open

https://www.youtube.com/watch?v=vOv_1Nl-rPg

I wasn't able to reproduce this issue on master 57cc05c7

Comment 1

[Aaron Train [:aaronmt]]

I can reproduce right off the bat off of master today (5918595)

=> Visit http://polygon.com
=> Long tap on the first link article at the top
=> Open in New Tab / Private Tab

Nothing happens.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8756320 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1851

Nice catch!

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Merged.

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Regression caused by Bug 1270865.

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1851

Comment 6

[Simon Basca [:SimonB]]

Tested on build Open new tab via context menu is working as expected on build 5979d61c.