Get Active Element incorrectly returns element reference instead of web element

RESOLVED FIXED in Firefox 49

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks 1 bug, {pi-marionette-server})

Version 3
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

3 years ago
The getActiveElement function in testing/marionette/listener.js incorrectly returns the element’s associated web element reference (UUID) as a string instead of a web element object representation.
Assignee

Updated

3 years ago
Assignee: nobody → ato
Blocks: webdriver
Assignee

Updated

3 years ago
Depends on: 1274274
Assignee

Comment 1

3 years ago
Making this depend on bug 1274274 as that contains a refactor of the element store we need to use to solve this bug, and because I don’t like conflicts I will address this after that lands.
Comment on attachment 8756823 [details]
MozReview Request: Bug 1274550 - Return web element from Get Active Element; r?automatedtester

https://reviewboard.mozilla.org/r/55430/#review52192
Attachment #8756823 - Flags: review?(dburns) → review+
Attachment #8756824 - Flags: review?(dburns) → review+
Comment on attachment 8756824 [details]
MozReview Request: Bug 1274550 - Simplify test case for get_active_element; r?automatedtester

https://reviewboard.mozilla.org/r/55432/#review52194
Comment on attachment 8756825 [details]
MozReview Request: Bug 1274550 - Make get_active_element in Python client backwards compatible; r?automatedtester

https://reviewboard.mozilla.org/r/55434/#review52198

::: testing/marionette/client/marionette_driver/marionette.py:1682
(Diff revision 1)
>  
> -
>      def get_active_element(self):
> -        el = self._send_message("getActiveElement", key="value")
> +        el_or_ref = self._send_message("getActiveElement", key="value")
> +        if self.protocol < 3:
> -        return HTMLElement(self, el)
> +            return HTMLElement(self, el)

This needs to be updated to `el_or_ref`
Attachment #8756825 - Flags: review?(dburns) → review+
Assignee

Comment 8

3 years ago
Comment on attachment 8756823 [details]
MozReview Request: Bug 1274550 - Return web element from Get Active Element; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55430/diff/1-2/
Assignee

Comment 9

3 years ago
Comment on attachment 8756824 [details]
MozReview Request: Bug 1274550 - Simplify test case for get_active_element; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55432/diff/1-2/
Assignee

Comment 10

3 years ago
Comment on attachment 8756825 [details]
MozReview Request: Bug 1274550 - Make get_active_element in Python client backwards compatible; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55434/diff/1-2/

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8218106c37b4
https://hg.mozilla.org/mozilla-central/rev/cdac1e9c5416
https://hg.mozilla.org/mozilla-central/rev/dd558e06d595
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee

Updated

3 years ago
Duplicate of this bug: 1280516
You need to log in before you can comment on or make changes to this bug.