1274550 - Get Active Element incorrectly returns element reference instead of web element

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The getActiveElement function in testing/marionette/listener.js incorrectly returns the element’s associated web element reference (UUID) as a string instead of a web element object representation.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Making this depend on bug 1274274 as that contains a refactor of the element store we need to use to solve this bug, and because I don’t like conflicts I will address this after that lands.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1274550 - Return web element from Get Active Element; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/55430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55430/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1274550 - Simplify test case for get_active_element; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/55432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55432/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1274550 - Make get_active_element in Python client backwards compatible; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/55434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55434/

Comment 5

[David Burns :automatedtester]

Comment on attachment 8756823 [details]
MozReview Request: Bug 1274550 - Return web element from Get Active Element; r?automatedtester

https://reviewboard.mozilla.org/r/55430/#review52192

Comment 6

[David Burns :automatedtester]

Comment on attachment 8756824 [details]
MozReview Request: Bug 1274550 - Simplify test case for get_active_element; r?automatedtester

https://reviewboard.mozilla.org/r/55432/#review52194

Comment 7

[David Burns :automatedtester]

Comment on attachment 8756825 [details]
MozReview Request: Bug 1274550 - Make get_active_element in Python client backwards compatible; r?automatedtester

https://reviewboard.mozilla.org/r/55434/#review52198

::: testing/marionette/client/marionette_driver/marionette.py:1682
(Diff revision 1)
>  
> -
>      def get_active_element(self):
> -        el = self._send_message("getActiveElement", key="value")
> +        el_or_ref = self._send_message("getActiveElement", key="value")
> +        if self.protocol < 3:
> -        return HTMLElement(self, el)
> +            return HTMLElement(self, el)

This needs to be updated to `el_or_ref`

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8756823 [details]
MozReview Request: Bug 1274550 - Return web element from Get Active Element; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55430/diff/1-2/

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8756824 [details]
MozReview Request: Bug 1274550 - Simplify test case for get_active_element; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55432/diff/1-2/

Comment 10

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8756825 [details]
MozReview Request: Bug 1274550 - Make get_active_element in Python client backwards compatible; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55434/diff/1-2/

Comment 11

[Andreas Tolfsen ❲:ato❳]

https://reviewboard.mozilla.org/r/55434/#review52224

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8218106c37b4
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdac1e9c5416
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd558e06d595

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8218106c37b4
https://hg.mozilla.org/mozilla-central/rev/cdac1e9c5416
https://hg.mozilla.org/mozilla-central/rev/dd558e06d595

Comment 14

[David Burns :automatedtester]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef8c8e02e8b2