1274615 - Remove/update css in browser/themes/osx now when we've dropped support for 10.6-10.8

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Stefan [:stefanh]]

I can do this later on when I'm back from vacation unless someone else picks it up.

Comment 1

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Attachment: MozReview Request: Bug 1274615 - Remove/update css in browser/themes/osx now when we've dropped support for 10.6-10.8. r?Gijs

Review commit: https://reviewboard.mozilla.org/r/55066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55066/

Comment 2

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

I can't test it. Try builds and tests are at https://treeherder.mozilla.org/#/jobs?repo=try&revision=949a5dcad891

Comment 3

[:Gijs (he/him)]

Comment on attachment 8756281 [details]
MozReview Request: Bug 1274615 - Remove/update css in browser/themes/osx now when we've dropped support for 10.6-10.8. r?Gijs

https://reviewboard.mozilla.org/r/55066/#review51748

Based on looking through the code several times, and some casual manual testing, this looks fine. Shame mozscreenshots is MIA, but meh - we managed before we had it, so...

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c57a0e71e7cd

Comment 5

[Matthew N. [:MattN] (PM me if requests are blocking you)]

Note that this missed https://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/browser.inc#7

I filed bug 1276537 to remove remaining fullscreen CSS and code. I'll file another for obsolete jar.mn overrides.

(In reply to :Gijs Kruitbosch from comment #3)
> Shame mozscreenshots is MIA

Note sure if this is what you mean but they weren't even requested… Aryx, for the future see https://developer.mozilla.org/en-US/docs/Mozilla/QA/Browser_screenshots

Comment 6

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] (behind on reviews) from comment #5)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Shame mozscreenshots is MIA
> 
> Note sure if this is what you mean but they weren't even requested… Aryx,
> for the future see
> https://developer.mozilla.org/en-US/docs/Mozilla/QA/Browser_screenshots

We retriggered on try and got no files... I filed a separate bug about this which you know about already, that pointed to the relevant csets. :-\

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c57a0e71e7cd