Remove/update css in browser/themes/osx now when we've dropped support for 10.6-10.8

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: stefanh, Assigned: aryx)

Tracking

Trunk
Firefox 49
Unspecified
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
I can do this later on when I'm back from vacation unless someone else picks it up.
Created attachment 8756281 [details]
MozReview Request: Bug 1274615 - Remove/update css in browser/themes/osx now when we've dropped support for 10.6-10.8. r?Gijs

Review commit: https://reviewboard.mozilla.org/r/55066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55066/
Attachment #8756281 - Flags: review?(gijskruitbosch+bugs)
I can't test it. Try builds and tests are at https://treeherder.mozilla.org/#/jobs?repo=try&revision=949a5dcad891
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED

Comment 3

2 years ago
Comment on attachment 8756281 [details]
MozReview Request: Bug 1274615 - Remove/update css in browser/themes/osx now when we've dropped support for 10.6-10.8. r?Gijs

https://reviewboard.mozilla.org/r/55066/#review51748

Based on looking through the code several times, and some casual manual testing, this looks fine. Shame mozscreenshots is MIA, but meh - we managed before we had it, so...
Attachment #8756281 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/c57a0e71e7cd
Note that this missed https://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/browser.inc#7

I filed bug 1276537 to remove remaining fullscreen CSS and code. I'll file another for obsolete jar.mn overrides.

(In reply to :Gijs Kruitbosch from comment #3)
> Shame mozscreenshots is MIA

Note sure if this is what you mean but they weren't even requested… Aryx, for the future see https://developer.mozilla.org/en-US/docs/Mozilla/QA/Browser_screenshots
Depends on: 1255589

Comment 6

2 years ago
(In reply to Matthew N. [:MattN] (behind on reviews) from comment #5)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Shame mozscreenshots is MIA
> 
> Note sure if this is what you mean but they weren't even requested… Aryx,
> for the future see
> https://developer.mozilla.org/en-US/docs/Mozilla/QA/Browser_screenshots

We retriggered on try and got no files... I filed a separate bug about this which you know about already, that pointed to the relevant csets. :-\

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c57a0e71e7cd
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.