Provide separate storage for browsers

RESOLVED FIXED in Firefox 48

Status

Testing
Marionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks: 1 bug, {ateam-marionette-server})

Version 3
mozilla49
ateam-marionette-server
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Marionette currently uses the ElementManager/element.Store from testing/marionette/element.js to store known browsers/windows by their outerWindowID.

This works, but to store and access them the caller needs to access the internal data structure properties of the store as the outerWindowID is used as a custom key.  Normally stored elements will have a web element reference (UUID) assigned.

To implement bug 1274251 we will anyway have to provide a separate storage for browsers to avoid mixup of Window objects when looking for duplicates when adding new elements to the store.
(Assignee)

Updated

2 years ago
Assignee: nobody → ato
Blocks: 1274251
Status: NEW → ASSIGNED
Keywords: ateam-marionette-server
(Assignee)

Comment 1

2 years ago
Created attachment 8755358 [details]
MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester

Windows do not naturally belong in the seen element store, and it is
not naturally related to the scope as that of a browser.

Review commit: https://reviewboard.mozilla.org/r/54570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54570/
Attachment #8755358 - Flags: review?(dburns)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8755358 [details]
MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54570/diff/1-2/
(Assignee)

Comment 3

2 years ago
Comment on attachment 8755358 [details]
MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54570/diff/2-3/
Comment on attachment 8755358 [details]
MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester

https://reviewboard.mozilla.org/r/54570/#review51250
Attachment #8755358 - Flags: review?(dburns) → review+

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6da876371bb4

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6da876371bb4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
https://hg.mozilla.org/releases/mozilla-aurora/rev/314e202438de
status-firefox48: --- → fixed

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/314e202438de
You need to log in before you can comment on or make changes to this bug.