Closed
Bug 1274638
Opened 8 years ago
Closed 8 years ago
Provide separate storage for browsers
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
Marionette currently uses the ElementManager/element.Store from testing/marionette/element.js to store known browsers/windows by their outerWindowID. This works, but to store and access them the caller needs to access the internal data structure properties of the store as the outerWindowID is used as a custom key. Normally stored elements will have a web element reference (UUID) assigned. To implement bug 1274251 we will anyway have to provide a separate storage for browsers to avoid mixup of Window objects when looking for duplicates when adding new elements to the store.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Windows do not naturally belong in the seen element store, and it is not naturally related to the scope as that of a browser. Review commit: https://reviewboard.mozilla.org/r/54570/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54570/
Attachment #8755358 -
Flags: review?(dburns)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8755358 [details] MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54570/diff/1-2/
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8755358 [details] MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54570/diff/2-3/
Comment 4•8 years ago
|
||
Comment on attachment 8755358 [details] MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester https://reviewboard.mozilla.org/r/54570/#review51250
Attachment #8755358 -
Flags: review?(dburns) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6da876371bb4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/314e202438de
status-firefox48:
--- → fixed
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/314e202438de
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•