Closed Bug 1274638 Opened 3 years ago Closed 3 years ago

Provide separate storage for browsers

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

Marionette currently uses the ElementManager/element.Store from testing/marionette/element.js to store known browsers/windows by their outerWindowID.

This works, but to store and access them the caller needs to access the internal data structure properties of the store as the outerWindowID is used as a custom key.  Normally stored elements will have a web element reference (UUID) assigned.

To implement bug 1274251 we will anyway have to provide a separate storage for browsers to avoid mixup of Window objects when looking for duplicates when adding new elements to the store.
Assignee: nobody → ato
Blocks: 1274251
Status: NEW → ASSIGNED
Windows do not naturally belong in the seen element store, and it is
not naturally related to the scope as that of a browser.

Review commit: https://reviewboard.mozilla.org/r/54570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54570/
Attachment #8755358 - Flags: review?(dburns)
Comment on attachment 8755358 [details]
MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54570/diff/1-2/
Comment on attachment 8755358 [details]
MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54570/diff/2-3/
Comment on attachment 8755358 [details]
MozReview Request: Bug 1274638 - Store weak refs to windows outside of element store; r?automatedtester

https://reviewboard.mozilla.org/r/54570/#review51250
Attachment #8755358 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/6da876371bb4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.