1274658 - [Windows] [Mac OS X] Resize grippy misoriented and wrong cursor direction in sideways-rl writing-mode

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Gérard Talbot]

Test
----

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/form-controls-srl-005.htm


Actual
------

The resizing grippy is oriented like /// .
When the cursor hovers over the resizing grippy of the textarea, the cursor is se-resize .


Expected
--------
The resizing grippy should be instead oriented like \\\ . So, it should be rotated 90 degrees clock-wise from its actual orientation.

When the cursor hovers over the resizing grippy of the textarea, the cursor should be sw-resize . 


Notes
-----

- This spun from bug 1274368 comment 1 :
"
For the srl testcase, OS X displays that in a wrong orientation like what you described in comment 0. In addition, for that testcase, the cursor on both OS X and Windows has wrong direction.
"
- I personally do not have and do not use Windows nor Mac OS X, so I can not answer questions. Please direct your questions to Xidorn Quan
- I've searched for duplicates and did not find any.

Comment 1

[Gérard Talbot]

We may also need to check with tests
<div style="resize: both;">
the other 3 vertical writing-modes.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Resizer needs to recognize sideways-rl as a "right-to-left" mode for orientation of the icon/cursor

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8755002 [details] [diff] [review]
Resizer needs to recognize sideways-rl as a "right-to-left" mode for orientation of the icon/cursor

Review of attachment 8755002 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

(Though: it seems like this will only fix the second half of the EXPECTED RESULTS -- about the cursor orientation.

The first half -- about the /// vs \\\ grippy-corner -- is broken for me in sideways-rl *as well as* vertical-rl writing-modes right now. So I don't think this change will fix that part, since it's simply broadening an existing vertical-rl scenario.)

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> Comment on attachment 8755002 [details] [diff] [review]
> Resizer needs to recognize sideways-rl as a "right-to-left" mode for
> orientation of the icon/cursor
> 
> Review of attachment 8755002 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me
> 
> (Though: it seems like this will only fix the second half of the EXPECTED
> RESULTS -- about the cursor orientation.
> 
> The first half -- about the /// vs \\\ grippy-corner -- is broken for me in
> sideways-rl *as well as* vertical-rl writing-modes right now. So I don't
> think this change will fix that part, since it's simply broadening an
> existing vertical-rl scenario.)

You're on Linux, aren't you? In which case I think that is a separate, gtk-widget-specific issue; see bug 1274368. The patch here fixes the /// vs \\\ display issue for me on OS X, at least.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95517d1a640b4557c7b9e45eec5d999df0479f0f
Bug 1274658 - Resizer needs to recognize sideways-rl as a "right-to-left" mode for orientation of the icon/cursor. r=dholbert

Comment 6

[Daniel Holbert [:dholbert]]

Ah, ok -- yes, I am indeed on Linux.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95517d1a640b