1274672 - taskcluster-vcs fails to checkout tooltool

Status: RESOLVED WONTFIX

(Taskcluster :: General, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I'm working on a new spidermonkey build in taskcluster, and I want to run + debug it locally rather than via try push, but I can't for the life of me get tc-vcs to checkout tooltool. I am cribbing off of existing SM builds in spidermonkey, and the tc-vcs + tooltool incantations are identical to the extant builds.

Here is what it looks like:

> $ tc-vcs checkout /Users/fitzgen/workspace/tooltool https://github.com/fitzgen/tooltool.git https://github.com/fitzgen/tooltool.git master
> [taskcluster-vcs] detectHg: start fetching head of https://github.com/fitzgen/tooltool.git
> [taskcluster-vcs] detectHg: end fetching head of https://github.com/fitzgen/tooltool.git
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git remote add origin https://github.com/fitzgen/tooltool.git
> fatal: 'origin' is not a valid remote name
> [taskcluster-vcs:warning] run end (with error) NOT RETRYING!: git remote add origin https://github.com/fitzgen/tooltool.git
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git fetch -f https://github.com/fitzgen/tooltool.git master:refs/remotes/origin/master
> fatal: Invalid refspec 'master:refs/remotes/origin/master'
> [taskcluster-vcs:warning] run end (with error) try (0/1) retrying in 8234.444734407589 ms : git fetch -f https://github.com/fitzgen/tooltool.git master:refs/remotes/origin/master
> [taskcluster-vcs] 1 run start : (cwd: /Users/fitzgen/workspace/tooltool) git fetch -f https://github.com/fitzgen/tooltool.git master:refs/remotes/origin/master
> fatal: Invalid refspec 'master:refs/remotes/origin/master'
> [taskcluster-vcs:error] run end (with error) NOT RETRYING!: git fetch -f https://github.com/fitzgen/tooltool.git master:refs/remotes/origin/master
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git reset --hard
> HEAD is now at a1f415a Merge djmitche/build-tooltool:fix-client-tests (PR #5)
> [taskcluster-vcs] run end : git reset --hard (0) in 7 ms
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git checkout master
> Already on 'master'
> Your branch is up-to-date with 'origin/master'.
> [taskcluster-vcs] run end : git checkout master (0) in 6 ms
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git merge origin/master
> merge: origin/master - not something we can merge
> [taskcluster-vcs:error] run end (with error) NOT RETRYING!: git merge origin/master
> Error: Error running command: git merge origin/master
>     at Error (native)
>     at run$ (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/build/run.js:128:15)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at GeneratorFunctionPrototype.invoke (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:209:22)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at Function.step (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:103:22)
> /Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/build/bin/tc-vcs.js:58
>         throw err;
>         ^
> 
> Error: Error running command: git merge origin/master
>     at Error (native)
>     at run$ (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/build/run.js:128:15)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at GeneratorFunctionPrototype.invoke (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:209:22)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at Function.step (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:103:22)

I believe this is this line[0]'s command failing. Not sure if this is a hard failure, or if it can be ignored. Seems silly to try and merge the thing we just checked out, but I'm not sure exactly whats up here...

[0] https://github.com/taskcluster/taskcluster-vcs/blob/master/src/vcs/git.js#L72

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

FWIW, I get the same results when trying to checkout tooltool from https://git.mozilla.org/build/tooltool.git

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

> $ tc-vcs --version
> 2.3.35

Comment 3

[Greg Arndt [:garndt]]

Are you attempting to do this in a directory that already contains a git checkout, specifically a checkout not made with tc-vcs before?

Could you try this same checkout in a location that never had a clone before just for the sake of it?

I attempted here [1] real quick in a task using tc-vcs 2.3.35 and it didn't seem to fail so I'm trying to pinpoint environmental differences that might contribute to it.

[1] https://tools.taskcluster.net/task-inspector/#ahUbkCsrQuygxfaO_bMOdQ/0

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I tried rm -rf ~/workspace between attempts, and it makes no difference:

> fitzgen@nfitzgerald-22150 :: (standalone-sm-ci) :: ~/src/mozilla-central
>     $ rm -rf ~/workspace/
> 
> fitzgen@nfitzgerald-22150 :: (standalone-sm-ci) :: ~/src/mozilla-central
>     $ ./testing/taskcluster/scripts/builder/build-sm-standalone.sh
> ++ dirname ./testing/taskcluster/scripts/builder/build-sm-standalone.sh
> + source ./testing/taskcluster/scripts/builder/sm-tooltool-config.sh
> ++ set -xe
> ++ : https://api.pub.build.mozilla.org/tooltool/
> ++ : https://git.mozilla.org/build/tooltool.git
> ++ : master
> ++ : plain
> ++ : /Users/fitzgen/artifacts/
> ++ : /Users/fitzgen/workspace
> ++ : /Users/fitzgen/workspace/build/src
> ++ mkdir -p /Users/fitzgen/workspace
> ++ cd /Users/fitzgen/workspace
> ++ case $(uname -m) in
> +++ uname -m
> ++ BITS=64
> ++ case "$OSTYPE" in
> ++ PLATFORM_OS=macosx
> ++ BROWSER_PLATFORM=macosx64
> ++ TOOLTOOL_MANIFEST=/Users/fitzgen/workspace/build/src/browser/config/tooltool-manifests/macosx64/releng.manifest
> ++ tc-vcs checkout --force-clone /Users/fitzgen/workspace/tooltool https://git.mozilla.org/build/tooltool.git https://git.mozilla.org/build/tooltool.git master
> [taskcluster-vcs] detectHg: start fetching head of https://git.mozilla.org/build/tooltool.git
> [taskcluster-vcs] detectHg: end fetching head of https://git.mozilla.org/build/tooltool.git
> [taskcluster-vcs] detectHg: start fetching head of https://git.mozilla.org/build/tooltool.git
> [taskcluster-vcs] detectHg: end fetching head of https://git.mozilla.org/build/tooltool.git
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace) tar -x -z --strip-components 1 -C /Users/fitzgen/workspace/tooltool -f /Users/fitzgen/.tc-vcs/clones/git.mozilla.org/build/tooltool.git.tar.gz
> [taskcluster-vcs] run end : tar -x -z --strip-components 1 -C /Users/fitzgen/workspace/tooltool -f /Users/fitzgen/.tc-vcs/clones/git.mozilla.org/build/tooltool.git.tar.gz (0) in 32 ms
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git fetch https://git.mozilla.org/build/tooltool.git
> From https://git.mozilla.org/build/tooltool
>  * branch            HEAD       -> FETCH_HEAD
> [taskcluster-vcs] run end : git fetch https://git.mozilla.org/build/tooltool.git (0) in 624 ms
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git remote add origin https://git.mozilla.org/build/tooltool.git
> fatal: 'origin' is not a valid remote name
> [taskcluster-vcs:warning] run end (with error) NOT RETRYING!: git remote add origin https://git.mozilla.org/build/tooltool.git
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git fetch -f https://git.mozilla.org/build/tooltool.git master:refs/remotes/origin/master
> fatal: Invalid refspec 'master:refs/remotes/origin/master'
> [taskcluster-vcs:warning] run end (with error) try (0/1) retrying in 9241.008979734033 ms : git fetch -f https://git.mozilla.org/build/tooltool.git master:refs/remotes/origin/master
> [taskcluster-vcs] 1 run start : (cwd: /Users/fitzgen/workspace/tooltool) git fetch -f https://git.mozilla.org/build/tooltool.git master:refs/remotes/origin/master
> fatal: Invalid refspec 'master:refs/remotes/origin/master'
> [taskcluster-vcs:error] run end (with error) NOT RETRYING!: git fetch -f https://git.mozilla.org/build/tooltool.git master:refs/remotes/origin/master
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git reset --hard
> HEAD is now at a1f415a Merge djmitche/build-tooltool:fix-client-tests (PR #5)
> [taskcluster-vcs] run end : git reset --hard (0) in 12 ms
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git checkout master
> Already on 'master'
> Your branch is up-to-date with 'origin/master'.
> [taskcluster-vcs] run end : git checkout master (0) in 8 ms
> [taskcluster-vcs] 0 run start : (cwd: /Users/fitzgen/workspace/tooltool) git merge origin/master
> merge: origin/master - not something we can merge
> [taskcluster-vcs:error] run end (with error) NOT RETRYING!: git merge origin/master
> Error: Error running command: git merge origin/master
>     at Error (native)
>     at run$ (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/build/run.js:128:15)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at GeneratorFunctionPrototype.invoke (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:209:22)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at Function.step (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:103:22)
> /Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/build/bin/tc-vcs.js:58
>         throw err;
>         ^
> 
> Error: Error running command: git merge origin/master
>     at Error (native)
>     at run$ (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/build/run.js:128:15)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at GeneratorFunctionPrototype.invoke (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:209:22)
>     at tryCatch (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:53:40)
>     at Function.step (/Users/fitzgen/.npmlibrary/lib/node_modules/taskcluster-vcs/node_modules/6to5/node_modules/regenerator-6to5/runtime.js:103:22)

Comment 5

[Steve Fink [:sfink] [:s:]]

The main difference I notice is that fitzgen is on osx. Not sure why that would matter.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

We have stopped using tc-vcs in favor of hg robustcheckout.