Move allocation of lowPrioNonrepCert into a block to destruct it before the goto for move analysis

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: Nika, Assigned: Nika)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8755009 [details] [diff] [review]
Move allocation of lowPrioNonrepCert into a block to destruct it before the goto for move analysis
Attachment #8755009 - Flags: review?(dkeeler)
Comment on attachment 8755009 [details] [diff] [review]
Move allocation of lowPrioNonrepCert into a block to destruct it before the goto for move analysis

Review of attachment 8755009 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer to review this either as a diff -w (i.e. ignore-white-space) or in reviewboard (which presents white-space-only changes more clearly).

::: security/manager/ssl/nsNSSIOLayer.cpp
@@ +2162,5 @@
>        goto noCert;
>      }
>  
> +    {
> +      UniqueCERTCertificate lowPrioNonrepCert;

Alternatively, you could just move this to the top of the function with everything else. This implementation already needs a lot of cleanup that's blocked by some other improvements. See bug 1267643 comment 3 for the plan.
Attachment #8755009 - Flags: review?(dkeeler)
Also, for future reference, pretty much only bugs on code in security/nss should be filed in the NSS product. Most of the rest of security/ falls in Core :: Security: PSM.
Component: Libraries → Security: PSM
Product: NSS → Core
Version: trunk → Trunk
Whiteboard: [psm-assigned]
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.