1274680 - Move allocation of lowPrioNonrepCert into a block to destruct it before the goto for move analysis

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Move allocation of lowPrioNonrepCert into a block to destruct it before the goto for move analysis

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8755009 [details] [diff] [review]
Move allocation of lowPrioNonrepCert into a block to destruct it before the goto for move analysis

Review of attachment 8755009 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer to review this either as a diff -w (i.e. ignore-white-space) or in reviewboard (which presents white-space-only changes more clearly).

::: security/manager/ssl/nsNSSIOLayer.cpp
@@ +2162,5 @@
>        goto noCert;
>      }
>  
> +    {
> +      UniqueCERTCertificate lowPrioNonrepCert;

Alternatively, you could just move this to the top of the function with everything else. This implementation already needs a lot of cleanup that's blocked by some other improvements. See bug 1267643 comment 3 for the plan.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Also, for future reference, pretty much only bugs on code in security/nss should be filed in the NSS product. Most of the rest of security/ falls in Core :: Security: PSM.