1274711 - Using IPCStream in an ipdl file requires including PFileDescriptorSet and PSendStream

Status: RESOLVED DUPLICATE of bug 792908

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

I added an argument of IPCStream to an IPDL file (uriloader/exthandler/PExternalHelperApp.ipdl), and also "include IPCStream". However, the resulting generated file did not compile until I also added "include protocol PFileDescriptorSet;" and "include protocol PSendStream;". It would be nice if I didn't have to include these, or at least the documentation for IPCStream should mention them.

Comment 1

[Andrew McCreight [:mccr8]]

Semi-relatedly, the documention example for AutoIPCStream should indicate that it is really mozilla::ipc::AutoIPCStream, or have a "using namespace mozilla::ipc;" in there somewhere.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

This is a geneeal ipdl issue.  I can find the bug when I get back to my computer.

Comment 3

[Andrew McCreight [:mccr8]]

Yeah, I wasn't sure if this was something you could fix, but you should at least add documentation about what needs to be included. :)

Comment 4

[Andrew Overholt [:overholt]]

ni(bkelly) for comment 3.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Someone should just fix bug 792908.  I think trying to document everywhere this is broken is going to be self defeating every time someone adds a new protocol somewhere.