Add %SYSTEM_CAPABILITIES% to the SeaMonkey app.update.url preference

RESOLVED FIXED in seamonkey2.47

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rstrong, Assigned: rsx11m.pub)

Tracking

(Depends on 1 bug)

unspecified
seamonkey2.47
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.44 unaffected, seamonkey2.45 fixed, seamonkey2.46 fixed, seamonkey2.47 fixed)

Details

Attachments

(2 attachments)

Also see bug 1274721 for Thunderbird for reference

In bug 1271761 a new value (%SYSTEM_CAPABILITIES%) will be added to the update url so it is possible to prevent updating of Windows systems that don't have SSE2 support.
Posted patch patch rev1Splinter Review
I'll let a SeaMonkey dev take the patch from here. This patch should not land until after the dependent bugs are fixed as well as aus2-community supports the new value. This will also need to be uplifted to Mozilla 48 and ESR if applicable for SeaMonkey.
(Assignee)

Updated

3 years ago
Component: Preferences → OS Integration
See Also: → 1274721
Summary: Add %SYSTEM_CAPABILITIES% to the app.update.url preference → Add %SYSTEM_CAPABILITIES% to the SeaMonkey app.update.url preference
(Assignee)

Comment 2

3 years ago
Comment on attachment 8755060 [details] [diff] [review]
patch rev1

This corresponds to attachment 8754955 [details] [diff] [review] for Firefox, the rest is Toolkit code.
Thus, it appears that this is all that's needed for SeaMonkey.

Patch applies to current trunk, so simply asking for review.
Attachment #8755060 - Flags: review?(philip.chee)
SeaMonkey uses aus2-community.mozilla.org
See attachment #8754681 [details] [diff] [review]

bhearsum discussed the server changes with Florian
See bug 1271761 comment #25
(Assignee)

Comment 4

3 years ago
Comment on attachment 8755060 [details] [diff] [review]
patch rev1

Thanks, I'm redirecting the review to ewong then in case this needs to be coordinated with the update services.
Attachment #8755060 - Flags: review?(philip.chee) → review?(ewong)
Comment on attachment 8755060 [details] [diff] [review]
patch rev1

Review of attachment 8755060 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/browser/browser-prefs.js
@@ +522,5 @@
>  // If set to true, the Update Service will present no UI for any event.
>  pref("app.update.silent", false);
>  
>  // Update service URL:
> +pref("app.update.url", "https://aus2-community.mozilla.org/update/6/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");

please change that to /3/.  There's little point in fixing all
the necessary backend to support /6/ since we hopefully will
move to balrog soon.

r+ with that changed and don't push yet.  Need to do some work
in the backend.
Attachment #8755060 - Flags: review?(ewong) → review+
(Assignee)

Comment 6

3 years ago
Robert's patch modified as requested (untested on my side).

This should land on comm-aurora as well, I don't know if this also needs to go into comm-beta after Monday's merges (probably yes).
Attachment #8759680 - Flags: review+
Attachment #8759680 - Flags: approval-comm-aurora?
(Assignee)

Comment 7

3 years ago
Comment on attachment 8759680 [details] [diff] [review]
Patch for checkin

Per bug 1271761 comment #47, this will have to be uplifted to comm-beta after today's merge.
Attachment #8759680 - Flags: approval-comm-beta?

Comment 8

3 years ago
Comment on attachment 8759680 [details] [diff] [review]
Patch for checkin

a=me for c-a/c-b
Attachment #8759680 - Flags: approval-comm-beta?
Attachment #8759680 - Flags: approval-comm-beta+
Attachment #8759680 - Flags: approval-comm-aurora?
Attachment #8759680 - Flags: approval-comm-aurora+
(Assignee)

Comment 9

3 years ago
(In reply to Edmund Wong (:ewong) from comment #5)
> r+ with that changed and don't push yet.  Need to do some work in the backend.

Ewong, please let me know when to push this to all channels, or just push it yourself when it's ready to land (all the dependencies to the core bugs are satisfied, afaict).
Flags: needinfo?(ewong)
Depends on: 1279402

Updated

3 years ago
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
(In reply to rsx11m from comment #9)
> (In reply to Edmund Wong (:ewong) from comment #5)
> > r+ with that changed and don't push yet.  Need to do some work in the backend.
> 
> Ewong, please let me know when to push this to all channels, or just push it
> yourself when it's ready to land (all the dependencies to the core bugs are
> satisfied, afaict).

Please push it to all channels.  I haven't been able to do anything and
instead of delaying this,  just push it and I'll deal with the aftermath.
Worse comes to worse,  there's no update and since there's nothing to update
from, there's no change there.
Flags: needinfo?(ewong)
(Assignee)

Comment 11

3 years ago
Ok, done.

http://hg.mozilla.org/comm-central/rev/261cbca4681a
http://hg.mozilla.org/releases/comm-aurora/rev/dedc7000c465
http://hg.mozilla.org/releases/comm-beta/rev/a48724969d5a (unbitrotted)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.47
You need to log in before you can comment on or make changes to this bug.