1274722 - Add %SYSTEM_CAPABILITIES% to the SeaMonkey app.update.url preference

Status: RESOLVED FIXED

(SeaMonkey :: OS Integration, defect)

Description

[Robert Strong (they/them - no direct email)]

Also see bug 1274721 for Thunderbird for reference

In bug 1271761 a new value (%SYSTEM_CAPABILITIES%) will be added to the update url so it is possible to prevent updating of Windows systems that don't have SSE2 support.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

I'll let a SeaMonkey dev take the patch from here. This patch should not land until after the dependent bugs are fixed as well as aus2-community supports the new value. This will also need to be uplifted to Mozilla 48 and ESR if applicable for SeaMonkey.

Comment 2

[rsx11m]

Comment on attachment 8755060 [details] [diff] [review]
patch rev1

This corresponds to attachment 8754955 [details] [diff] [review] for Firefox, the rest is Toolkit code.
Thus, it appears that this is all that's needed for SeaMonkey.

Patch applies to current trunk, so simply asking for review.

Comment 3

[Robert Strong (they/them - no direct email)]

SeaMonkey uses aus2-community.mozilla.org
See attachment #8754681 [details] [diff] [review]

bhearsum discussed the server changes with Florian
See bug 1271761 comment #25

Comment 4

[rsx11m]

Comment on attachment 8755060 [details] [diff] [review]
patch rev1

Thanks, I'm redirecting the review to ewong then in case this needs to be coordinated with the update services.

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 8755060 [details] [diff] [review]
patch rev1

Review of attachment 8755060 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/browser/browser-prefs.js
@@ +522,5 @@
>  // If set to true, the Update Service will present no UI for any event.
>  pref("app.update.silent", false);
>  
>  // Update service URL:
> +pref("app.update.url", "https://aus2-community.mozilla.org/update/6/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");

please change that to /3/.  There's little point in fixing all
the necessary backend to support /6/ since we hopefully will
move to balrog soon.

r+ with that changed and don't push yet.  Need to do some work
in the backend.

Comment 6

[rsx11m]

Attachment: Patch for checkin

Robert's patch modified as requested (untested on my side).

This should land on comm-aurora as well, I don't know if this also needs to go into comm-beta after Monday's merges (probably yes).

Comment 7

[rsx11m]

Comment on attachment 8759680 [details] [diff] [review]
Patch for checkin

Per bug 1271761 comment #47, this will have to be uplifted to comm-beta after today's merge.

Comment 8

[Ian Neal]

Comment on attachment 8759680 [details] [diff] [review]
Patch for checkin

a=me for c-a/c-b

Comment 9

[rsx11m]

(In reply to Edmund Wong (:ewong) from comment #5)
> r+ with that changed and don't push yet.  Need to do some work in the backend.

Ewong, please let me know when to push this to all channels, or just push it yourself when it's ready to land (all the dependencies to the core bugs are satisfied, afaict).

Comment 10

[Edmund Wong (:ewong)]

(In reply to rsx11m from comment #9)
> (In reply to Edmund Wong (:ewong) from comment #5)
> > r+ with that changed and don't push yet.  Need to do some work in the backend.
> 
> Ewong, please let me know when to push this to all channels, or just push it
> yourself when it's ready to land (all the dependencies to the core bugs are
> satisfied, afaict).

Please push it to all channels.  I haven't been able to do anything and
instead of delaying this,  just push it and I'll deal with the aftermath.
Worse comes to worse,  there's no update and since there's nothing to update
from, there's no change there.

Comment 11

[rsx11m]

Ok, done.

http://hg.mozilla.org/comm-central/rev/261cbca4681a
http://hg.mozilla.org/releases/comm-aurora/rev/dedc7000c465
http://hg.mozilla.org/releases/comm-beta/rev/a48724969d5a (unbitrotted)