Rename corruptedContentError string to reflect new content

RESOLVED FIXED in Firefox 49

Status

()

--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: flod, Assigned: mcmanus)

Tracking

43 Branch
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Changes were introduced in 
http://hg.mozilla.org/mozilla-central/rev/7521936774c1

This string now needs a new ID. 

This change has caused warnings on the dashboard (least of the issues), but unless we use a new ID we'll keep using existing outdated strings without the variable in it.
(Reporter)

Comment 1

3 years ago
And to further clarify, even the string change alone without the variable would have required a new string ID.
(Reporter)

Comment 2

3 years ago
NI to make sure this is visible.
Flags: needinfo?(mcmanus)
(Assignee)

Comment 3

3 years ago
I forgot about this. it sounds like you know what the patch should look like - can you do draft it?
Flags: needinfo?(mcmanus)
(Reporter)

Comment 4

3 years ago
(In reply to Patrick McManus [:mcmanus] from comment #3)
> I forgot about this. it sounds like you know what the patch should look like
> - can you do draft it?

Not really, for once because I currently wouldn't be able to test a patch. Also, it needs to be fixed as soon as possible (before it slips to aurora), and it should be extremely quick for someone familiar with the code.
(Assignee)

Comment 6

3 years ago
Created attachment 8755445 [details] [diff] [review]
corrupted content string management
Attachment #8755445 - Flags: review?(dd.mozilla)
Attachment #8755445 - Flags: review?(dd.mozilla) → review+
Comment hidden (obsolete)
(Assignee)

Updated

3 years ago
Attachment #8755489 - Attachment is obsolete: true
Attachment #8755489 - Flags: review?(dd.mozilla)
Whiteboard: [necko-active]
(Reporter)

Updated

3 years ago
Keywords: checkin-needed

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/195c5c599588
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.