Closed
Bug 1274729
Opened 8 years ago
Closed 8 years ago
Rename corruptedContentError string to reflect new content
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: flod, Assigned: mcmanus)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file, 1 obsolete file)
21.49 KB,
patch
|
dragana
:
review+
|
Details | Diff | Splinter Review |
Changes were introduced in http://hg.mozilla.org/mozilla-central/rev/7521936774c1 This string now needs a new ID. This change has caused warnings on the dashboard (least of the issues), but unless we use a new ID we'll keep using existing outdated strings without the variable in it.
Reporter | ||
Comment 1•8 years ago
|
||
And to further clarify, even the string change alone without the variable would have required a new string ID.
Assignee | ||
Comment 3•8 years ago
|
||
I forgot about this. it sounds like you know what the patch should look like - can you do draft it?
Flags: needinfo?(mcmanus)
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Patrick McManus [:mcmanus] from comment #3) > I forgot about this. it sounds like you know what the patch should look like > - can you do draft it? Not really, for once because I currently wouldn't be able to test a patch. Also, it needs to be fixed as soon as possible (before it slips to aurora), and it should be extremely quick for someone familiar with the code.
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc70b6fb438d
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8755445 -
Flags: review?(dd.mozilla)
Updated•8 years ago
|
Attachment #8755445 -
Flags: review?(dd.mozilla) → review+
Comment hidden (obsolete) |
Assignee | ||
Updated•8 years ago
|
Attachment #8755489 -
Attachment is obsolete: true
Attachment #8755489 -
Flags: review?(dd.mozilla)
Updated•8 years ago
|
Whiteboard: [necko-active]
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/195c5c59958883a19851ddf5a3016fecf6fb034e Bug 1274729 - corrupted content string management r=dragana
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/195c5c599588
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•