Closed Bug 1274729 Opened 4 years ago Closed 4 years ago

Rename corruptedContentError string to reflect new content

Categories

(Core :: Networking, defect)

43 Branch
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: flod, Assigned: mcmanus)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

Changes were introduced in 
http://hg.mozilla.org/mozilla-central/rev/7521936774c1

This string now needs a new ID. 

This change has caused warnings on the dashboard (least of the issues), but unless we use a new ID we'll keep using existing outdated strings without the variable in it.
And to further clarify, even the string change alone without the variable would have required a new string ID.
NI to make sure this is visible.
Flags: needinfo?(mcmanus)
I forgot about this. it sounds like you know what the patch should look like - can you do draft it?
Flags: needinfo?(mcmanus)
(In reply to Patrick McManus [:mcmanus] from comment #3)
> I forgot about this. it sounds like you know what the patch should look like
> - can you do draft it?

Not really, for once because I currently wouldn't be able to test a patch. Also, it needs to be fixed as soon as possible (before it slips to aurora), and it should be extremely quick for someone familiar with the code.
Attachment #8755445 - Flags: review?(dd.mozilla)
Attachment #8755445 - Flags: review?(dd.mozilla) → review+
Attachment #8755489 - Attachment is obsolete: true
Attachment #8755489 - Flags: review?(dd.mozilla)
Whiteboard: [necko-active]
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/195c5c599588
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.