Closed
Bug 1274746
Opened 8 years ago
Closed 7 years ago
Print custom size Scale dialog always needs a new and different value entered.
Categories
(Core :: Print Preview, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: cjg.aptl, Assigned: bobowen)
Details
Attachments
(1 file)
1.52 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 Build ID: 20160502160818 Steps to reproduce: Load a page. Select Print (goes to print preview page) On size drop-down box, select "Custom" There is likely to be a value already entered, say 75(%). Do not change this value. Hit return to "use" this entered value Actual results: The scale displayed does not change, stays on previously used scale (e.g. shrink to fit) Expected results: It should display at the pre-existing scale value present. ----- In order to get the page to display at a custom scale, you have to enter a value, which must be different from the pre-existing value, then it works. So if you often use a particular scale (say 75%), you have to enter a different value (say 74%), hit return, then select the scale and enter the value you want (75%). Long winded for what should respond on the original "return"/ "OK" exit from the dialog
Assignee | ||
Comment 1•7 years ago
|
||
The change here is to make the prompt return the value even if it hasn't changed, because we still need to reprocess if we are switching from Shrink To Fit.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bobowencode
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Updated•7 years ago
|
Attachment #8904506 -
Flags: review?(dtownsend)
Updated•7 years ago
|
Attachment #8904506 -
Flags: review?(dtownsend) → review?(mconley)
Comment 2•7 years ago
|
||
Comment on attachment 8904506 [details] [diff] [review] Use previous custom scale value when switching from Shrink To Fit in Print Preview Review of attachment 8904506 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8904506 -
Flags: review?(mconley) → review+
Pushed by bobowencode@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3316ee67aa Use previous custom scale value when switching from Shrink To Fit in Print Preview. r=mconley
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ad3316ee67aa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•