Closed Bug 1274749 Opened 8 years ago Closed 8 years ago

Useless one free space between dropmarker and separator in address bar

Categories

(Firefox :: Theme, defect)

49 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 49
Tracking Status
firefox48 --- unaffected
firefox49 + verified

People

(Reporter: Virtual, Assigned: baku)

References

Details

(4 keywords)

Attachments

(3 files, 1 obsolete file)

Opening new window in Nightly will get dropmarker moved one place to the left of its normal position, opening new tab fixes the issue in this window.

[Tracking Requested - why for this release]: Regression
Attached patch fix.patch (obsolete) — Splinter Review
Flags: needinfo?(amarchesini)
Attachment #8755220 - Flags: review?(gijskruitbosch+bugs)
Assignee: nobody → amarchesini
Comment on attachment 8755220 [details] [diff] [review]
fix.patch

I can reproduce this on inbound tip from a few minutes ago, but this patch does not apply there, so I don't know how to review this / what this is supposed to be doing (and, if the code you're changing here isn't there yet, it feels like it also won't fix the issue that we're dealing with already on Nightly).
Attachment #8755220 - Flags: review?(gijskruitbosch+bugs)
Attached patch fix.patchSplinter Review
Attachment #8755220 - Attachment is obsolete: true
Attachment #8755396 - Flags: review?(gijskruitbosch+bugs)
Attachment #8755396 - Flags: review?(gijskruitbosch+bugs) → review+
Tracking this for 49 as we have a patch and would be good to fix.
https://hg.mozilla.org/mozilla-central/rev/c2954f2b8ab7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Why is this element not just hidden by default, i.e. <hbox id="userContext-icons" hidden="true">?
Flags: needinfo?(amarchesini)
Depends on: 1276116
Dao, you are right. Can you file a follow up?
Flags: needinfo?(amarchesini)
(In reply to Andrea Marchesini (:baku) from comment #12)
> Dao, you are right. Can you file a follow up?

Done. It's in bug #1276585.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: