Closed Bug 1274753 Opened 4 years ago Closed 4 years ago

Remove unused nsIEnumerator from Becky Mail import.

Categories

(MailNews Core :: Import, defect)

All
Unspecified
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(1 file)

\mailnews\import\becky\src\nsBeckyMail.cpp contains an apparently unused reference to nsIEnumerator.h which is obsolete and can be removed.
Removes the header import.
Attachment #8755116 - Flags: review?(m_kato)
Comment on attachment 8755116 [details] [diff] [review]
1274753-nsienumerator.patch

I'm sure Aceman can review the removal of one line. So could I ;-)
Attachment #8755116 - Flags: review?(m_kato) → review?(acelists)
>> I'm sure Aceman can review the removal of one line. So could I ;-)

You never know. These are usially the tricky ones :)
Comment on attachment 8755116 [details] [diff] [review]
1274753-nsienumerator.patch

Review of attachment 8755116 [details] [diff] [review]:
-----------------------------------------------------------------

I can't properly build it (it is for Windows only), but globally we do not want any nsIEnumerator in mailnews (this is the single one). And yes it seems unused. So assuming you have built with this, I think I can give r+ :)

Thanks for noticing it.
Attachment #8755116 - Flags: review?(acelists) → review+
Thanks and yes, I did build with it.

https://hg.mozilla.org/comm-central/rev/5408cfbe2a30
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.