1274826 - apps are constantly crashing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jovan Gerodetti]

Attachment: adb logcat output

With my build from today every app crashes instantly. 
The homescreen is constantly restarting.

Gaia: 0f0db431054adad34c9f402d3e22ab7f54975a44
Gecko: 298617:88534aee6c1b

Comment 1

[asppsa]

I see roughly the same thing on a Nexus 4 build I have just completed.

Gaia: 2c0e66f09a6f12219bb13e806ca4ba4a30eae74e (kanikani)
Gecko: 298617:88534aee6c1b (pine)

Comment 3

[:gerard-majax]

And I don't reproduce on desktop/mulet even after forcing OOP ?

Comment 4

[:gerard-majax]

Attachment: boot_pine+m-c_20160525.log

Comment 5

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #3)
> And I don't reproduce on desktop/mulet even after forcing OOP ?

Checking |adb shell b2g-ps| I can see lots of processes spawn/dying, pointing to maybe NUWA broken :/

Comment 6

[:gerard-majax]

Given the past buildability state of m-c it's going to be tough to try any bisect for this issue. I am doing a build without NUWA to confirm whether this is because of it or not.

Comment 7

[:gerard-majax]

I can confirm with MOZ_NUWA_PROCESS disabled the issue is still happening :/

Comment 8

[:gerard-majax]

Attachment: no_nuwa_debug.log

Logcat with NUWA disabled and B2G_DEBUG=1

Comment 9

[:gerard-majax]

So when I disable the sandbox (--disable-sandbox --disable-content-sandbox) then I have no more error ! This gives us some string to pull :)

Comment 10

[:gerard-majax]

cf comment 9

Comment 11

[:gerard-majax]

local revert of bug 1176099 and I do not reproduce the issue anymore!

Comment 12

[:gerard-majax]

Jed, Julian, does it makes any sense to have this SandboxHooks machinery from bug 1176099 on B2G ? And if it makes sense, what are the risks of not making use of it?

Comment 13

[:gerard-majax]

fact: if I ifdef exclude sigprocmask(), no problem.

Comment 14

[:gerard-majax]

Looks like we do not get a function out of dlsym(). Man shows that RTLD_NEXT is only available when built with _GNU_SOURCE.

Comment 15

[:gerard-majax]

Maybe RTLD_NEXT is bugged on bionic (on ours?). Anyway, dlsym() against a handle from a dlopen("libc.so") and it works.

Comment 16

[:gerard-majax]

Attachment: Force looking into libc.so on Gonk for sandbox hooks r=...

MozReview-Commit-ID: AegVwuPx4uU

Comment 17

[:gerard-majax]

Comment on attachment 8756447 [details] [diff] [review]
Force looking into libc.so on Gonk for sandbox hooks r=...

So, maybe RTLD_NEXT is broken on bionic, I still need to check this. But in the meantime, here is a patch that should not break desktop and make it working on Gonk. Asking feedback to know if you agree with this approach?

Comment 18

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

The sigprocmask interception is needed only if there are libraries that create threads that block all signals.  We didn't run into any problems with that on B2G, so I think it would make sense to just not build SandboxHooks on B2G.

Comment 19

[:gerard-majax]

https://sourceware.org/bugzilla/show_bug.cgi?id=1319

Comment 20

[:gerard-majax]

(In reply to Jed Davis [:jld] [away until 06-01] [⏰MDT; UTC-6] from comment #18)
> The sigprocmask interception is needed only if there are libraries that
> create threads that block all signals.  We didn't run into any problems with
> that on B2G, so I think it would make sense to just not build SandboxHooks
> on B2G.

Sure, tell me whathever you prefer between just not building this on B2G or the patch I submitted :)

Comment 21

[Julian Hector [:tedd] [:jhector]]

I agree with Jed, the code isn't required on B2G, so not building it seems like the better option.

Comment 22

[:gerard-majax]

Attachment: MozReview Request: Bug 1274826 - Bypass building SandboxHooks on Gonk r?jld

Review commit: https://reviewboard.mozilla.org/r/55278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55278/

Comment 23

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8756611 [details]
MozReview Request: Bug 1274826 - Bypass building SandboxHooks on Gonk r?jld

https://reviewboard.mozilla.org/r/55278/#review52080

Comment 24

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1743abeb2352

Comment 25

[:gerard-majax]

https://hg.mozilla.org/projects/pine/rev/69fee7f7624a

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1743abeb2352