Closed
Bug 1274834
Opened 9 years ago
Closed 9 years ago
Printing in full screen mode gives a screen with no access to the print button
Categories
(Firefox :: Untriaged, defect)
Tracking
()
VERIFIED
FIXED
Firefox 49
People
(Reporter: rwza01, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
dao
:
review+
Sylvestre
:
approval-mozilla-beta-
|
Details |
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151223140742
Steps to reproduce:
(Using FirefoxPortable_43.0.3_English downloaded from portableapps.com on Jan 5 2016 at 3:12 pm SAST)
1) View a web page in full screen mode
2) Print the page (move cursor to top of screen so that tabs and menus appear, click on three horizontal bars, click on print)
3) Try to press the print button that (should, but does not) appear
Actual results:
4) Moving the cursor to the top of the screen doesn't make the buttons appear and hence it is not possible to press the print button and so you have to hit <escape> to leave full screen mode - then the print button (and the other buttons) appears and you can print
Expected results:
4) Either moving the cursor to the top of the screen should make the print button appear, or printing in full screen mode should not give a full screen print preview but rather should automatically make the print button visible
Comment 1•9 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=391241169bec&tochange=1f7db5d87e80
Regressed by 1f7db5d87e80 Dão Gottwald — Bug 1176233 - Simplify fullscreen code. r=xidorn
Blocks: 1176233
Status: UNCONFIRMED → NEW
status-firefox46:
--- → affected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox49:
--- → affected
status-firefox-esr38:
--- → unaffected
status-firefox-esr45:
--- → affected
Ever confirmed: true
Flags: needinfo?(dao+bmo)
Keywords: regression
Assignee | ||
Updated•9 years ago
|
Blocks: fx-fullscreen
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54498/
Attachment #8755268 -
Flags: review?(dao+bmo)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bugzilla
Updated•9 years ago
|
Flags: needinfo?(dao+bmo)
Attachment #8755268 -
Flags: review?(dao+bmo) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
Too late for 46/47, we are just a couple of weeks away from 47 release.
But this could still make it into 48 if the fix is verified and you request uplift.
Keywords: checkin-needed
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 6•8 years ago
|
||
Xidorn, are you going to request for an uplift in beta? Thanks
Flags: needinfo?(bugzilla)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8755268 [details]
MozReview Request: Bug 1274834 - Make print preview toolbar a fullscreentoolbar. r?dao
Approval Request Comment
[Feature/regressing bug #]: bug 1176233
[User impact if declined]: cannot access print preview toolbar in fullscreen mode
[Describe test coverage new/current, TreeHerder]: no test coverage
[Risks and why]: low risk, should not affect anything other than this specific case
[String/UUID change made/needed]: n/a
I don't think it's worth uplifting... But it isn't risky either. So if you think it's worth, then it's worth...
Flags: needinfo?(bugzilla)
Attachment #8755268 -
Flags: approval-mozilla-beta?
Comment 8•8 years ago
|
||
Comment on attachment 8755268 [details]
MozReview Request: Bug 1274834 - Make print preview toolbar a fullscreentoolbar. r?dao
I trust your judgment! Let it ride the train from 49 then! Thanks for your time
Attachment #8755268 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Updated•8 years ago
|
Comment 9•8 years ago
|
||
I've reproduced the initial issue on Nightly 49 (2016-05-22).
Verified fixed on Firefox 49 Beta 1 (buildID: 20160802125918) on Windows 7 x64.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•