Closed
Bug 1274861
Opened 8 years ago
Closed 8 years ago
compile error in testThreadingConditionVariable.cpp
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1273639
People
(Reporter: stevensn, Assigned: stevensn)
Details
Attachments
(1 file)
|
5.97 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Some missing namespace qualifiers is causing js/src/jsapi-tests/testThreadingConditionVariable.cpp:39:18: error: \u2018MakeUnique\u2019 was not declared in this scope
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → steve
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8755225 -
Flags: review?(terrence)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8755225 [details] [diff] [review] Add mozilla namespace prefix to MakeUnique Review of attachment 8755225 [details] [diff] [review]: ----------------------------------------------------------------- Thank you, again!
Attachment #8755225 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a87397f78b3
Keywords: checkin-needed
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
failed to apply: patching file js/src/jsapi-tests/testThreadingConditionVariable.cpp Hunk #1 FAILED at 30 Hunk #2 FAILED at 80 Hunk #3 FAILED at 106 Hunk #4 FAILED at 157 Hunk #5 FAILED at 183 5 out of 5 hunks FAILED -- saving rejects to file js/src/jsapi-tests/testThreadingConditionVariable.cpp.rej patch failed, unable to continue (try -v)
Flags: needinfo?(steve)
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•8 years ago
|
||
Bug 1273639 has already landed and has the same changes
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(steve)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•