1274928 - Add a mechanism to preinstall external webapps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1274928-clock-external > mozilla-b2g:kanikani

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8756370 [details] [review]
[gaia] albertopq:1274928-clock-external > mozilla-b2g:kanikani

Ben, what do you think about this approach? There is a missing step for updating the pinned manifest if the url has a link rel="manifest", in order to always keep the last one.

Note that the clock app is just an example. We should point to mozilla-b2g.github.io instead. 

* I used https://github.com/mozilla-b2g/preload-app-toolkit for generating the hosted_apps/clock folder

Comment 3

[Ben Francis [:benfrancis]]

I think this is basically the right approach and I realise you're trying to not to touch too much code, but I do think this can be simplified.

How about a JSON file with an array of web app manifests (e.g. https://github.com/benfrancis/gecko-dev/blob/b2g-tablet/b2g/chrome/content/shared/defaults/sites.json) and we just populate the Places database from that on first run? (e.g. https://github.com/benfrancis/gecko-dev/blob/b2g-tablet/b2g/chrome/content/shared/js/Places.js#L77)

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 8756370 [details] [review]
[gaia] albertopq:1274928-clock-external > mozilla-b2g:kanikani

So we're now using Facebook as an example web app? Fair enough.

I think this can be improved but at least this gets a basic mechanism working to pre-install web apps.

Comment 5

[Alberto Pastor [:albertopq]]

kanikani: https://github.com/mozilla-b2g/gaia/commit/99978a001603702ff18d93ffdc0bb8202572f3b9