Closed Bug 1275038 Opened 4 years ago Closed 4 years ago

Remove regexp clone analysis with hoist analysis

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: h4writer, Assigned: h4writer)

References

Details

Attachments

(1 file)

Patch
6.14 KB, patch
jandem
: review+
Details | Diff | Splinter Review 
We currently have two places where we do analysis on MRegExp in order to know if we can safely hoist or not clone it. We should unify them.
Attached patch Patch — — Splinter Review 
MakeMRegExpHoistable is the more complete one. The analysis happening during lowering doesn't do a lot anymore.
Assignee: nobody → hv1989
Attachment #8755492 - Flags: review?(jdemooij)
Depends on: 1260435
Comment on attachment 8755492 [details] [diff] [review]
Patch

Review of attachment 8755492 [details] [diff] [review]:
-----------------------------------------------------------------

Great!
Attachment #8755492 - Flags: review?(jdemooij) → review+
Pushed by hv1989@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/539bcdf33f32
IonMonkey: Remove regexp clone analysis in favor of hoist analysis, r=jandem
https://hg.mozilla.org/mozilla-central/rev/539bcdf33f32
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1304640
You need to log in before you can comment on or make changes to this bug.