Closed
Bug 1275038
Opened 5 years ago
Closed 5 years ago
Remove regexp clone analysis with hoist analysis
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: h4writer, Assigned: h4writer)
References
Details
Attachments
(1 file)
6.14 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
We currently have two places where we do analysis on MRegExp in order to know if we can safely hoist or not clone it. We should unify them.
Assignee | ||
Comment 1•5 years ago
|
||
MakeMRegExpHoistable is the more complete one. The analysis happening during lowering doesn't do a lot anymore.
Assignee: nobody → hv1989
Attachment #8755492 -
Flags: review?(jdemooij)
Comment 2•5 years ago
|
||
Comment on attachment 8755492 [details] [diff] [review] Patch Review of attachment 8755492 [details] [diff] [review]: ----------------------------------------------------------------- Great!
Attachment #8755492 -
Flags: review?(jdemooij) → review+
Pushed by hv1989@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/539bcdf33f32 IonMonkey: Remove regexp clone analysis in favor of hoist analysis, r=jandem
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/539bcdf33f32
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•