Closed
Bug 1275082
Opened 8 years ago
Closed 8 years ago
Can't do toPrivate() on a RootedValue
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: terrence)
Details
Attachments
(1 file)
2.55 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
It won't compile. I assume because ValueOperations doesn't include it? Is this purposeful? Not sure who has blame for this stuff; or VCS is lying to me.
Flags: needinfo?(terrence)
Assignee | ||
Comment 1•8 years ago
|
||
No, I must have just missed it when building ValueOperations.
Assignee: nobody → terrence
Status: NEW → ASSIGNED
Flags: needinfo?(terrence)
Attachment #8755572 -
Flags: review?(sphink)
Comment 2•8 years ago
|
||
Comment on attachment 8755572 [details] [diff] [review] add_toPrivate-v0.diff Review of attachment 8755572 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, that's kinda weird.
Attachment #8755572 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5191bafd5e34d392785f5114dcbaa6d0a3b2ed2e Bug 1275082 - Add missing ValueOperations private accessors; r=sfink
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5191bafd5e34
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•