1275093 - Various webkit-text-stroke-property reftests are going to permafail when Gecko 48 merges to Beta

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Merge day permafail when Gecko 48 hits Beta.

Interestingly, this only appears to affect Gecko 48. Did we land something on 49 that needs backporting? Merge day is two weeks away, so this is fairly urgent.

https://treeherder.mozilla.org/logviewer.html#?job_id=20982461&repo=try#L27261

Comment 1

[Daniel Holbert [:dholbert]]

The webkit-text-stroke feature is guarded by the "layout.css.prefixes.webkit" pref, which in Firefox 48 is configured to be default-disabled in beta/release build, and default-enabled in nightly/aurora builds.

We need to add
 user_pref("layout.css.prefixes.webkit", true);
to the top of the manifest file, like we have in e.g. the webkit-gradient reftest manifest here:
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/webkit-gradient/reftest.list#3

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

This should do it.

Comment 3

[Daniel Holbert [:dholbert]]

Try run of Aurora (at the same cset as RyanVM's try push), with this patch as well as RyanVM's aurora-as-beta patch:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0636df938f34

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 8755578 [details] [diff] [review]
fix v1

Review of attachment 8755578 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, assuming try is happy with it.

Comment 5

[Daniel Holbert [:dholbert]]

Thanks for the review!

Try run looks good.  Setting ni=me to land on inbound and then aurora [with a=testonly] once inbound is open.

Comment 6

[Jeremy Chen ([e-mail])]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> The webkit-text-stroke feature is guarded by the
> "layout.css.prefixes.webkit" pref, which in Firefox 48 is configured to be
> default-disabled in beta/release build, and default-enabled in
> nightly/aurora builds.
> 
> We need to add
>  user_pref("layout.css.prefixes.webkit", true);
> to the top of the manifest file, like we have in e.g. the webkit-gradient
> reftest manifest here:
> http://mxr.mozilla.org/mozilla-central/source/layout/reftests/webkit-
> gradient/reftest.list#3

Just woke up and found this. I should've added the default pref setting at the first time.

Daniel and Jonathan, thank you for taking care of this so quickly. :)

Comment 7

[Daniel Holbert [:dholbert]]

Sure! I figured I'd just jump on it, since it's simple.

(Tree's closed again, boo. Hopefully I can land this later tonight. :))

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca9dfc88461d

Comment 9

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9b9a73a98de8

Comment 10

[Daniel Holbert [:dholbert]]

--> Fixed for firefox 48 and 49 (the only versions that support this webkit-text-stroke feature).

(As noted in comment 0, technically 49 didn't need a tweak; that's because of bug 1259345. Still, good for consistency's sake to declare the prefs that reftests depend on, as long as those prefs exist.)

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca9dfc88461d