Closed Bug 1275093 Opened 3 years ago Closed 3 years ago

Various webkit-text-stroke-property reftests are going to permafail when Gecko 48 merges to Beta

Categories

(Core :: Layout: Text and Fonts, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox47 --- unaffected
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: RyanVM, Assigned: dholbert)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Merge day permafail when Gecko 48 hits Beta.

Interestingly, this only appears to affect Gecko 48. Did we land something on 49 that needs backporting? Merge day is two weeks away, so this is fairly urgent.

https://treeherder.mozilla.org/logviewer.html#?job_id=20982461&repo=try#L27261
Flags: needinfo?(jeremychen)
The webkit-text-stroke feature is guarded by the "layout.css.prefixes.webkit" pref, which in Firefox 48 is configured to be default-disabled in beta/release build, and default-enabled in nightly/aurora builds.

We need to add
 user_pref("layout.css.prefixes.webkit", true);
to the top of the manifest file, like we have in e.g. the webkit-gradient reftest manifest here:
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/webkit-gradient/reftest.list#3
Attached patch fix v1Splinter Review
This should do it.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8755578 - Flags: review?(jfkthame)
Flags: needinfo?(jeremychen)
Try run of Aurora (at the same cset as RyanVM's try push), with this patch as well as RyanVM's aurora-as-beta patch:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0636df938f34
Whiteboard:
Whiteboard:
Comment on attachment 8755578 [details] [diff] [review]
fix v1

Review of attachment 8755578 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, assuming try is happy with it.
Attachment #8755578 - Flags: review?(jfkthame) → review+
Thanks for the review!

Try run looks good.  Setting ni=me to land on inbound and then aurora [with a=testonly] once inbound is open.
Flags: needinfo?(dholbert)
(In reply to Daniel Holbert [:dholbert] from comment #1)
> The webkit-text-stroke feature is guarded by the
> "layout.css.prefixes.webkit" pref, which in Firefox 48 is configured to be
> default-disabled in beta/release build, and default-enabled in
> nightly/aurora builds.
> 
> We need to add
>  user_pref("layout.css.prefixes.webkit", true);
> to the top of the manifest file, like we have in e.g. the webkit-gradient
> reftest manifest here:
> http://mxr.mozilla.org/mozilla-central/source/layout/reftests/webkit-
> gradient/reftest.list#3

Just woke up and found this. I should've added the default pref setting at the first time.

Daniel and Jonathan, thank you for taking care of this so quickly. :)
Sure! I figured I'd just jump on it, since it's simple.

(Tree's closed again, boo. Hopefully I can land this later tonight. :))
--> Fixed for firefox 48 and 49 (the only versions that support this webkit-text-stroke feature).

(As noted in comment 0, technically 49 didn't need a tweak; that's because of bug 1259345. Still, good for consistency's sake to declare the prefs that reftests depend on, as long as those prefs exist.)
https://hg.mozilla.org/mozilla-central/rev/ca9dfc88461d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.