1275095 - test_get_last_visited.html is going to permafail when Gecko 49 merges to Beta

Status: VERIFIED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=20978022&repo=try#L3831

13:38:29     INFO -  247 INFO TEST-START | mobile/android/tests/browser/chrome/test_get_last_visited.html
13:38:52     INFO -  248 INFO SpawnTask.js | Entering test test_get_last_visited
13:38:52     INFO -  249 INFO TEST-UNEXPECTED-FAIL | mobile/android/tests/browser/chrome/test_get_last_visited.html | No listeners for request
13:38:52     INFO -  add_task/</<@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:282:15
13:38:52     INFO -  onRejected@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:85:15
13:38:52     INFO -  250 INFO TEST-OK | mobile/android/tests/browser/chrome/test_get_last_visited.html | took 18193ms

Comment 1

[Lina Butler [:lina]]

jchen, is this related to bug 1267419?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

I think it's because MOZ_ANDROID_GCM is only enabled for nightly builds.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Andrew, I'm being told that the DOM team should own this. Can you please help find an assignee?

Comment 4

[Andrew Overholt [:overholt]]

William, can you investigate?

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 49, we should fix this within the next aurora cycle.

Comment 6

[William Chen [:wchen]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #2)
> I think it's because MOZ_ANDROID_GCM is only enabled for nightly builds.

You're right. The test sends a message [1] that is only handled when MOZ_ANDROID_CGM is enabled [2] because we don't register the message event listeners [3] otherwise.

[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/browser/chrome/test_get_last_visited.html#29
[2] https://dxr.mozilla.org/mozilla-central/rev/4d63dde701b47b8661ab7990f197b6b60e543839/mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java#192
[3] https://dxr.mozilla.org/mozilla-central/rev/4d63dde701b47b8661ab7990f197b6b60e543839/mobile/android/base/java/org/mozilla/gecko/push/PushService.java#222

The "History:GetPrePathLastVisitedTimeMilliseconds" event doesn't actually depend on the PushService (although it's the only consumer) so we could move it somewhere else.

However, I think it's better for now to modify the test to only run when MOZ_ANDROID_CGM is enabled since the test is testing "History:GetPrePathLastVisitedTimeMilliseconds" and in the current code that only makes sense when MOZ_ANDROID_CGM is enabled.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Enable MOZ_ANDROID_CGM for all builds (v1)

Currently, MOZ_ANDROID_CGM is only enabled for Nightly builds. We want
to enable it for all builds and let it ride the trains through 48.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8758813 [details] [diff] [review]
Enable MOZ_ANDROID_CGM for all builds (v1)

Review of attachment 8758813 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops!

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jim please make sure this gets uplifted to 48 as well.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edcb7e44c957
Enable MOZ_ANDROID_CGM for all builds; r=snorp

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8758813 [details] [diff] [review]
Enable MOZ_ANDROID_CGM for all builds (v1)

Uplifting to 48.

Approval Request Comment
[Feature/regressing bug #]: Push
[User impact if declined]: Push notifications will not work
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Very small; patch turns on build flag for Aurora, and that build flag has been on in Nightly for a while
[String/UUID change made/needed]: None

Comment 12

[Marcia Knous [:marcia]]

Based on Comment 7, tracking this for 48 and marking the 48 branch as affected.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/edcb7e44c957

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8758813 [details] [diff] [review]
Enable MOZ_ANDROID_CGM for all builds (v1)

Let's uplift this before the merge so that push notifications will work.

Comment 15

[Carsten Book [:Tomcat]]

has problems to uplift like 

Tomcats-MacBook-Pro-2:mozilla-central Tomcat$ hg graft --edit -r edcb7e44c957
grafting 348229:edcb7e44c957 "Bug 1275095 - Enable MOZ_ANDROID_CGM for all builds; r=snorp"
merging mobile/android/moz.configure
warning: conflicts while merging mobile/android/moz.configure! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 16

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* try: 5

Platform breakdown:
* android-4-3-armv7-api15: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1275095&startday=2016-05-30&endday=2016-06-05&tree=all

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

snorp if you have a chance, can you have a look at the merge conflict and give us a hand getting this landed on aurora? Thanks. I figure maybe Jim is traveling already for the work week.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

(see comment 17)

Comment 19

[Lina Butler [:lina]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6845cc4241af

Comment 20

[Lina Butler [:lina]]

Rebased and uplifted. Could we please uplift bug 1278851 so that `ServiceWorkerRegistration::showNotification` works, too?

Comment 21

[Michelle Funches - QA]

Verified
Fennec 48.0b1
Build ID 20160607197837
User Agent Mozilla/5.0 (Android 4.2.2; Tablet; rv:48.0) Gecko/48.0 Firefox/48.0

Comment 22

[Ryan VanderMeulen [:RyanVM]]

How are you verifying a test-only fix?

Comment 23

[Michelle Funches - QA]

Comment 21 should be deleted, was not paying attention to where I posted. Thanks