Closed Bug 1275104 (akita-chat-displaynames) Opened 8 years ago Closed 8 years ago

put basic static displayname support in akita

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

(Whiteboard: [akita-alpha])

User Story

As a Hello user, I can see chat comments from more than just the room owner and one other participant, so that multiple people can discuss the decision being made.

Acceptance criteria:

* multiple speakers are shown at once, in way where each is visibly distinct
* name of speaker shown by each chat bubble

Attachments

(1 file, 1 obsolete file)

Link to Github pull-request: https://github.com/mozilla/loop/pull/474
40 bytes, text/x-github-pull-request
mancas
: review+
Details | Review 
      No description provided.
Whiteboard: [akita-alpha]
Rank: 19
Priority: -- → P1
Rank: 19 → 12
Summary: support multiple users in chat → UI to support multiple users in chat
Assignee: nobody → dmose

        Attachment #8758548 -
        Attachment is obsolete: true

        Attachment #8758549 -
        Flags: review?(dpreston)

        Attachment #8758549 -
        Flags: review?(b.mcb)

    
    

    
  
Comment on attachment 8758549 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/474

Looks fine. r=me with nit fixed

        Attachment #8758549 -
        Flags: review?(dpreston)

        Attachment #8758549 -
        Flags: review?(b.mcb)

        Attachment #8758549 -
        Flags: review+

    
    

    
  
Landed: https://github.com/mozilla/loop/commit/e86bd18665efaa7428930d01e7224fbce53bbc95

I'm going to push the remaining UI bits (using display names from Firebase) into bug 1274172.
Status: NEW → RESOLVED
Closed: 8 years ago
No longer depends on: akita-multiuser-chat
Resolution: --- → FIXED
Alias: akita-multiuser-chat → akita-chat-displaynames
Summary: UI to support multiple users in chat → put basic static displayname support in akita

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: