Closed Bug 1275122 Opened 9 years ago Closed 9 years ago

Remove "review" path from firefoxtree repo

Categories

(Developer Services :: Mercurial: firefoxtree, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

No description provided.
This was added in the very early days of MozReview. I just watched it confuse a new contributor because they couldn't figure out where the "review" path was coming from. This automagical definition of this path is nice. But if anything it should be part of the mozreview extension, not firefoxtree. Review commit: https://reviewboard.mozilla.org/r/54710/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54710/
Attachment #8755638 - Flags: review?(smacleod)
Comment on attachment 8755638 [details] MozReview Request: firefoxtree: remove "review" path (bug 1275122); r?smacleod https://reviewboard.mozilla.org/r/54710/#review51888
Attachment #8755638 - Flags: review?(smacleod) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
I got the following error after I did ./mach mercurial-setup. $ hg push review abort: repository review does not exist! One of my colleagues bumps into the same issue today. I guess many people might rely on the automagic setup of the review path. Anyway, I resolve the issue by setting the review path by following [1]. [1] https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install-mercurial.html#configuring-the-auto-review-repository
Presumably, this is how most of us who regularly use mozreview have been pushing to it, and now it's suddenly broken without any explanation. I gave up trying to find an explanation in the docs (which don't make it obvious that `autoreview` is meant to be the same thing as `review`) and had to grep through the commit history of version-control-tools before I understood what happened. I doubt that I'm going to be the only one with this problem.
I think we should backout this change. This does break the daily workflow without any explanation.
If this should be part of some other extension, that change should be done before removing the review path here, so that people never find their workflow broken.
File a new bug and we can add the path to the mozreview extension.
In the mean time, can someone please send a message to dev.platform and dev.firefox warning people about this change?
I don't think it is worth the spam. Aside from a few commenters in this bug, I haven't seen anything on IRC, which is usually the first place people complain about things like this.
Most people don't update their version control tools repo very often, except when mach requires them to. People are going to continue running into this as they update until there's a fix.
I just updated my v-c-t and got hit by this. I agree that it would have been nice to provide the functionality in another extension before removing it from this one. (In reply to Gregory Szorc [:gps] from comment #8) > File a new bug and we can add the path to the mozreview extension. Did someone end up filing a bug for this?
Run `mach mercurial-setup` and it will restore the "review" path.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: