[TV][Home] Pressing OK key when enlarged folder hold card inside be able to exceed upper bound number of cards

VERIFIED FIXED

Status

Firefox OS
Gaia::TV::Home
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: mlien, Assigned: Fischer)

Tracking

(Blocks: 2 bugs)

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.6?)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
[Testing Steps]
1. Add a new folder with 9 cards
2. Navigate to any card in main list
3. Press Option key -> Choose Move
4. Move card to overlap step 1's folder
5. Press OK key

[Expected result]
Should reject this card movement and show notification banner

[Actual result]
Card can be moved to this folder

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/5069e2af2d292be1b83475de3c3e0656e94f6395
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/9f233a9b2c912dc45021db56e215090e2b955975

Comment 1

a year ago
Created attachment 8755734 [details] [review]
[gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6
(Assignee)

Comment 2

a year ago
Comment on attachment 8755734 [details] [review]
[gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6

@Luke,
This patch checks the folder capacity before adding card into folder by pressing OK key, thanks
Attachment #8755734 - Flags: review?(lchang) review?(lchang)
(Assignee)

Comment 3

a year ago
Comment on attachment 8755734 [details] [review]
[gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6

@Luke,
This patch checks the folder capacity before adding card into folder by pressing OK key, thanks
(Assignee)

Updated

a year ago
Assignee: nobody → fliu
Comment on attachment 8755734 [details] [review]
[gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6

Looks good!
Attachment #8755734 - Flags: review?(lchang)
Attachment #8755734 - Flags: review+
(Assignee)

Comment 5

a year ago
Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Reporter)

Comment 6

a year ago
verified and fixed with the latest build
v2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.