Check nullptr on getInlineReturnTypeSet

RESOLVED INVALID

Status

()

Core
JavaScript Engine: JIT
RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: h4writer, Assigned: h4writer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I was just wandering in code, when I noticed that on trackTypeInfoUnchecked(CallInfo&) we assume getInlineReturnTypeSet will be none-null. That is not globally true, though ?maybe? in this case it could be true. However the check is quite easy and removes any doubt...
(Assignee)

Comment 1

2 years ago
Created attachment 8755729 [details] [diff] [review]
Patch
Assignee: nobody → hv1989
Attachment #8755729 - Flags: review?(shu)
When does it return nullptr? It seems to call bytecodeTypes -> TypeScript::BytecodeTypes.
(Assignee)

Comment 3

2 years ago
Definitely if script->types() is nullptr. Stopped looking further after that. But yeah that shouldn't happen.
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID

Comment 4

2 years ago
Comment on attachment 8755729 [details] [diff] [review]
Patch

Cancelling since bug was marked invalid.
Attachment #8755729 - Flags: review?(shu)
You need to log in before you can comment on or make changes to this bug.