1275200 - WebRTC: memory leak using DataChannel

Status: RESOLVED INVALID

(Core :: WebRTC, defect)

Description

[Sergio]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36

Steps to reproduce:

My windows application opens a DataChannel to Firefox and I transmit PNG images which will be displayed in a canvas object.


Actual results:

Firefox stops receiving data and Windows Task Manages shows a huge memory usage for Firefox, more than 700 MB. Firefox even crashes sometimes.


Expected results:

Firefox should free allocated memory and keep receiving data over the DataChannel.
Version 45.0.2 works correctly.

Comment 1

[Loic]

Could you type about:memory in the location bar, then save and attach a memory log when the issue appears.

In addition, could you provide a simple testcase to reproduce the issue.

Comment 2

[Sergio]

Attachment: memory-report.json.gz

Comment 3

[Sergio]

I just open a DataChannel and send many PNG images to it. I have just tested that the problem appears even so:

        var onDataChannelMessage = function (event) {
        }

I do nothing with the received data. I think you should be able to reproduce it. Maybe it depends how fast Firefox is receiving data.

Comment 4

[Paul Adenot (:padenot)]

106MB of heap-unclassified for 11MB of canvas pixel data, I call that a smoking gun.

Sergio, would you be able to give us a way to reproduce the problem so we can investigate?

Jesup, any idea off hand in this range (works in 45, does not work in 46).

Comment 5

[Sergio]

my windows application is sharing the desktop or just an application, applies PNG/JPEG compression and send the data over DTLS/SCTP to Firefox. 
It is difficult for me to provide you a way to reproduce the problem. 
But as I said, in the onDataChannelMessage associated with the DataChannel I just returned without doing anything with the data and the problem still persists.
The point is that I eventually send a high bitrate to Firefox, nearly 1MB/sec.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

How large are the messages?  Are they ArrayBuffers or Blobs?  Is the leak on the receiving side, or the sending side?  If need be, open two browsers on the same machine and make the call between them.  (./firefox -profilemanager -no-remote   will let you run multiple browsers and profiles easily)  Is this all over a single DataChannel? (I assume so).

Can you provoke a leak, then open a tab with about:memory and select Minimize Memory Usage, and see if the leak disappears.  Then close one of the tabs, Minimize again, and check.  Then the other tab, and repeat.  (This will also will help determine which side is the cause)

Thanks

Comment 7

[Sergio]

- different sizes, from 20 KB to some bytes
- ArrayBuffers
- Firefox only at the receiving side. Sending side is a windows application (.exe)

Comment 8

[Byron Campen [:bwc]]

Can you perform the diagnostic steps in comment 6? That should give us an idea of where the problem lies.

Comment 9

[Sergio]

i already attached a memory dump and as i said, there is only Firefox at the receiving side. I will try to do the diagnostic next week.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Sergio: Per comment 6, we would like a dump of about:memory after selecting Minimize Memory Usage.  (See comment 6).  I think it's just data waiting for GC, but if it isn't this will show that.  (Since Firefox is receiving data from a windows exe, you can ignore the "other tab" questions).  Thanks

Comment 11

[Sergio]

Hi, selecting Minimize Memory Usage did not help. I am not able to get a memory dump when Firefox is using over 800 MB, only till 600 MB. I hope you can find the problem. Thanks.

Comment 12

[Sergio]

Attachment: memory-report.json.gz

Comment 13

[Sergio]

Attachment: memory-report.json_min.gz

Comment 14

[Sergio]

Attachment: memory-report.json_min2.gz

Comment 15

[Sergio]

Attachment: memory.png

Comment 16

[Sergio]

I think we can close this issue, new version 47 works ok.