Closed
Bug 1275233
Opened 8 years ago
Closed 8 years ago
Web-platform-test form-validation-reportValidity.html use skip-if which is never true
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: jdai, Assigned: jdai)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file, 1 obsolete file)
1.09 KB,
patch
|
jdai
:
review+
|
Details | Diff | Splinter Review |
Web-platform-test shouldn't use skip-if. It cause form-validation-reportValidity web-platform-test has been skipped in all platform.
Comment 1•8 years ago
|
||
I guess we need to fix wpt annotations so that they don't let one to use things which it can't recognize. The current setup feels really error prone, and not something a review can easily catch.
Flags: needinfo?(james)
Comment 2•8 years ago
|
||
aha, I see, we use different syntax for wpt. skip-if = (os == 'mac') and debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1273105 should be something like if os == "mac": https://bugzilla.mozilla.org/show_bug.cgi?id=1273105 thought, I don't know how to express 'debug' there.
Comment 3•8 years ago
|
||
if os == "mac" and debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1273105 maybe? At least 'debug' is used elsewhere.
Comment 4•8 years ago
|
||
Yes. I don't think this is too weird; it's consistent with the rest of web-platform-tests and it would be super-weird to have to put all the expectation values on the left hand side of if expressions like error-if: and crash-if:. We could maybe lint for use of skip-if on the rhs, but it isn't something I have seen before so it's at least not obviously a common mistake.
Flags: needinfo?(james)
Updated•8 years ago
|
Whiteboard: btpp-active
Assignee | ||
Comment 5•8 years ago
|
||
Try result looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e6c9d1327d18c8279f06323ebcb7ebc050207b4
Attachment #8756671 -
Flags: review?(bugs)
Comment 6•8 years ago
|
||
Comment on attachment 8756671 [details] [diff] [review] Bug 1275233 - Web-platform-test shouldn't use skip-if. Drive-by review to help smaug's queue.
Attachment #8756671 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Attachment #8756671 -
Flags: review?(bugs)
Assignee | ||
Comment 7•8 years ago
|
||
Rename reviewer name.
Attachment #8756671 -
Attachment is obsolete: true
Attachment #8756763 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/94033f5e6555
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•