Web-platform-test form-validation-reportValidity.html use skip-if which is never true

RESOLVED FIXED in Firefox 49

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jdai, Assigned: jdai)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Web-platform-test shouldn't use skip-if. It cause form-validation-reportValidity web-platform-test has been skipped in all platform.

Comment 1

2 years ago
I guess we need to fix wpt annotations so that they don't let one to use things which it can't recognize. 
The current setup feels really error prone, and not something a review can easily catch.
Flags: needinfo?(james)

Comment 2

2 years ago
aha, I see, we use different syntax for wpt.
 
skip-if = (os == 'mac') and debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1273105
should be something like
if os == "mac": https://bugzilla.mozilla.org/show_bug.cgi?id=1273105

thought, I don't know how to express 'debug' there.

Comment 3

2 years ago
if os == "mac" and debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1273105

maybe? At least 'debug' is used elsewhere.
Yes. I don't think this is too weird; it's consistent with the rest of web-platform-tests and it would be super-weird to have to put all the expectation values on the left hand side of if expressions like error-if: and crash-if:.

We could maybe lint for use of skip-if on the rhs, but it isn't something I have seen before so it's at least not obviously a common mistake.
Flags: needinfo?(james)
Whiteboard: btpp-active
(Assignee)

Comment 5

2 years ago
Created attachment 8756671 [details] [diff] [review]
Bug 1275233 - Web-platform-test shouldn't use skip-if.

Try result looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e6c9d1327d18c8279f06323ebcb7ebc050207b4
Attachment #8756671 - Flags: review?(bugs)
Comment on attachment 8756671 [details] [diff] [review]
Bug 1275233 - Web-platform-test shouldn't use skip-if.

Drive-by review to help smaug's queue.
Attachment #8756671 - Flags: review+
(Assignee)

Updated

2 years ago
Attachment #8756671 - Flags: review?(bugs)
(Assignee)

Comment 7

2 years ago
Created attachment 8756763 [details] [diff] [review]
Bug 1275233 - Web-platform-test shouldn't use skip-if. r=jgraham

Rename reviewer name.
Attachment #8756671 - Attachment is obsolete: true
Attachment #8756763 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/94033f5e6555
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.