Closed
Bug 1275249
Opened 8 years ago
Closed 8 years ago
Firefox-ui-tests permafail due to get_attributes() no longer returning property values
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: whimboo, Assigned: ato)
References
Details
(Keywords: intermittent-failure, regression)
Attachments
(1 file)
On mozilla-inbound our functional-ui-tests are perma broken because of the backward incompatible change on bug 1272653: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Firefox%20UI&filter-tier=2&filter-tier=3 I wonder why we couldn't have left the fallback of using get_attribute() to return also values for properties, but mark it as deprecated. This change will cause us issues with our update tests which happen across releases.
Flags: needinfo?(ato)
Reporter | ||
Updated•8 years ago
|
Blocks: 1272653
Keywords: intermittent-failure,
regression
Reporter | ||
Comment 1•8 years ago
|
||
If it's a clear no-go to get fixed in a backward compatible manner in Marionette I have to check how to overlay that method from Marionette in our tests.
Assignee | ||
Comment 2•8 years ago
|
||
Yes, this is consciously a backwards breaking change in Marionette to align it with the WebDriver standard. The idea is that WebDriver local ends that want the old behaviour can do this by using the Get Element Attribute and Get Element Property primitives to emulate it, like this: def get_attribute(attr): res = _send_message("getElementAttribute", {"value": attr}, key="value") if res is None: res = _send_message("getElementProperty", {"value": attr}, key="value") return res In this particular case it looks like we need to replace four calls to get_attribute with get_property because they are fetching DOM properties in content. XUL and chrome space should not see any breakage as a result of bug 1272653.
Flags: needinfo?(ato)
Reporter | ||
Comment 3•8 years ago
|
||
I talked with Andreas on IRC and we decided the following: 1) Andreas will get those broken test failures fixed. 2) We will wait how update tests are working. If those are failing we have to find a backward compatible method as mentioned above. Otherwise we should be good. At least the comment that only content is affected makes me less nervous ;)
Assignee | ||
Comment 4•8 years ago
|
||
In bug 1272653, Get Element Attribute was split into Get Element Attribute for attributes and boolean attributes, and Get Element Property for properties. This patch addresses the fallout in the Firefox UI tests caused by those patches. Review commit: https://reviewboard.mozilla.org/r/54852/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54852/
Attachment #8755858 -
Flags: review?(hskupin)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8755858 [details] MozReview Request: Bug 1275249 - Update UI tests to get property where applicable; r?whimboo https://reviewboard.mozilla.org/r/54852/#review51492 Thanks Andreas! Lets get it landed so we have it on inbound before the next merge.
Attachment #8755858 -
Flags: review?(hskupin) → review+
Reporter | ||
Comment 6•8 years ago
|
||
I will add the leave-open keyword for this bug because we have to check how update tests are working and if we need a further patch.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Reporter | ||
Comment 8•8 years ago
|
||
The fix was not complete for the functional tests. There is at least one more test which has not been reported as failure earlier? TEST-UNEXPECTED-ERROR | test_security_notification.py TestSecurityNotification.test_invalid_cert | TypeError: argument of type 'NoneType' is not iterable Andreas, can you provide a followup fix? If you do, please run the full suite to ensure its complete then.
Flags: needinfo?(ato)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•8 years ago
|
||
In case the update tests are broken I will file a new bug. So lets get the leave-opne keyword removed.
Keywords: leave-open
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/011e172a9ddf
Comment hidden (Intermittent Failures Robot) |
Reporter | ||
Comment 14•8 years ago
|
||
The patch on bug 1272653 got backported to 48.0, but this patch for the test never got to that branch! Lets get it into mozilla-beta.
Comment 15•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f23397230676
Whiteboard: [checkin-needed-beta]
You need to log in
before you can comment on or make changes to this bug.
Description
•