1275256 - Crash in nsHTTPCompressConv::BrotliHandler

Status: RESOLVED DUPLICATE of bug 1274732

(Core :: Networking, defect)

Description

[Dragana Damjanovic [:dragana]]

There are not a lot of them.

I am not sure if there is something wrong with Brotli or with nsHTTPCompressConv in general.


https://crash-stats.mozilla.com/report/index/3c2d3400-0ee5-4f76-84e4-700612160515
https://crash-stats.mozilla.com/report/index/d9d94f0b-98e8-4d7d-a658-86cd82160511

Comment 1

[Patrick McManus [:mcmanus]]

https://crash-stats.mozilla.com/search/?signature=~nsHTTPCompressConv%3A%3ABrotliHandler&date=%3E2016-01-01&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

12 since the beginning of the year and just 1 in the last couple of weeks..

Comment 2

[Patrick McManus [:mcmanus]]

see https://bugzilla.mozilla.org/show_bug.cgi?id=1274732 .. maybe a dup .. maybe a str.. maybe just a non-official toolchain with a problem

Comment 3

[Natanael Copa]

It looks like this runs out of stack space: https://crash-stats.mozilla.com/report/index/d9d94f0b-98e8-4d7d-a658-86cd82160511

Might be an idea to allocate 128kb buffer with malloc instead of placing it on the stack.
https://hg.mozilla.org/releases/mozilla-aurora/annotate/9a64ae897313/netwerk/streamconv/converters/nsHTTPCompressConv.cpp#l169

Or maybe use a significantly smaller buffer.