Closed
Bug 1275266
Opened 8 years ago
Closed 8 years ago
Rename imgLoader::Singleton and imgLoader::PBSingleton to something less misleading, and document them
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
9.77 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
The method names Singleton and PBSingleton on imgLoader are misleading, especially at call sites where we only call Singleton(). (We can and do create multiple imgLoader instances.) The meaning of PBSingleton is also not obvious without digging into the code which isn't a very good way to figure out the meaning of an interface.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8755859 -
Flags: review?(tnikkel)
|
||
Updated•8 years ago
|
Attachment #8755859 -
Flags: review?(tnikkel) → review+
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2f3fc8f9ec43 https://hg.mozilla.org/mozilla-central/rev/b306ec471adf
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•