Closed
Bug 1275293
Opened 8 years ago
Closed 8 years ago
Fix screen sharing layout on Akita
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
Iteration:
49.3 - Jun 6
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [akita])
Attachments
(1 file)
Currently on Akita branch, the screen share gets displayed at a super large size, overlaying the text chat and generally isn't useful.
Since Ian and I keep trying to use it, I'm fixing the css.
|
Assignee | |
Comment 1•8 years ago
|
||
Note: Its easiest to see if you share something from a browser that's really wide.
|
|
Assignee | |
Comment 2•8 years ago
|
||
This fixes the styling for the screen share element. I've also removed a couple of obsolete .screen's and added a comment for later about focus-stream as I suspect we can remove that, but didn't want to mess more stuff up at the moment.
Attachment #8755893 -
Flags: review?(fernando.campo)
Attachment #8755893 -
Flags: review?(b.mcb)
|
||
Updated•8 years ago
|
Whiteboard: [akita]
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8755893 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/460
Looks good. r=me
Attachment #8755893 -
Flags: review?(fernando.campo)
Attachment #8755893 -
Flags: review?(b.mcb)
Attachment #8755893 -
Flags: review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Status: NEW → RESOLVED
Iteration: --- → 49.3 - Jun 6
Closed: 8 years ago
Rank: 5
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•