Closed
Bug 1275296
Opened 8 years ago
Closed 8 years ago
Increase Marionette DEFAULT_STARTUP_TIMEOUT
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
While working on bug 1272652 I executed test_reset_profile.py locally. The test kept failing on something that was looking like a timeout, after some searches I found: http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette_driver/marionette.py#537 DEFAULT_STARTUP_TIMEOUT = 60 60s is a very short time in some cases, for example in the migration case. On my i7, with a windows debug build, it was always hit. I just doubled it and it works locally, I don't know if there's any downsides from increasing this, apart from the fact a real failure could take a bit more time to be reported. Regardless I don't think the current timeout is realistic.
Assignee | ||
Updated•8 years ago
|
Summary: Increase DEFAULT_STARTUP_TIMEOUT → Increase Marionette DEFAULT_STARTUP_TIMEOUT
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54870/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54870/
Attachment #8755898 -
Flags: review?(dburns)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
That's similar to bug 1274039 but that includes also the shutdown time - where we kill Firefox after 1 min most of the time meanwhile.
See Also: → 1274039
Comment 3•8 years ago
|
||
Comment on attachment 8755898 [details] MozReview Request: Bug 1275296 - Increase Marionette DEFAULT_STARTUP_TIMEOUT. r=automatedtester https://reviewboard.mozilla.org/r/54870/#review51562
Attachment #8755898 -
Flags: review?(dburns) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/13da4ea2b371
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•