Closed Bug 1275296 Opened 4 years ago Closed 4 years ago

Increase Marionette DEFAULT_STARTUP_TIMEOUT

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

While working on bug 1272652 I executed test_reset_profile.py locally.
The test kept failing on something that was looking like a timeout, after some searches I found:

http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette_driver/marionette.py#537
DEFAULT_STARTUP_TIMEOUT = 60

60s is a very short time in some cases, for example in the migration case. On my i7, with a windows debug build, it was always hit.

I just doubled it and it works locally, I don't know if there's any downsides from increasing this, apart from the fact a real failure could take a bit more time to be reported.
Regardless I don't think the current timeout is realistic.
Summary: Increase DEFAULT_STARTUP_TIMEOUT → Increase Marionette DEFAULT_STARTUP_TIMEOUT
Assignee: nobody → mak77
Status: NEW → ASSIGNED
That's similar to bug 1274039 but that includes also the shutdown time - where we kill Firefox after 1 min most of the time meanwhile.
See Also: → 1274039
Comment on attachment 8755898 [details]
MozReview Request: Bug 1275296 - Increase Marionette DEFAULT_STARTUP_TIMEOUT. r=automatedtester

https://reviewboard.mozilla.org/r/54870/#review51562
Attachment #8755898 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/13da4ea2b371
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
See Also: → 1364228
You need to log in before you can comment on or make changes to this bug.