MozReview help menu items don't open in a new tab

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mars, Assigned: davidwalsh)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The MozReview help menu in the upper-right corner of the UI opens it's items in the current tab.  This surprised me - I expected reference documentation like 'User Guide' and 'Mercurial for Mozillians' to open in new tabs, so I don't lose what I was doing on my Review Board page, and so I can reference both the app and docs pages at the same time.

This also surprised me because other webapps I have used open external reference documentation in new tabs.
(Assignee)

Comment 1

3 years ago
Created attachment 8765982 [details]
MozReview: Open 'MozReview' header links in new window (Bug 1275305).

Review commit: https://reviewboard.mozilla.org/r/61066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61066/
Attachment #8765982 - Flags: review?(glob)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8765982 [details]
MozReview: Open 'MozReview' header links in new window (Bug 1275305).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61066/diff/1-2/
(Assignee)

Comment 3

3 years ago
https://reviewboard.mozilla.org/r/61066/#review57904

Sadly this is the best way to do this -- you cannot add `'target': 'blank'` to the item set for the `HeaderDropdownActionHook` :/
Assignee: nobody → dwalsh
Comment on attachment 8765982 [details]
MozReview: Open 'MozReview' header links in new window (Bug 1275305).

https://reviewboard.mozilla.org/r/61066/#review58048
Attachment #8765982 - Flags: review?(glob) → review+

Comment 5

3 years ago
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/35bb71e25f28
MozReview: Open 'MozReview' header links in new window . r=glob
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.