1275305 - MozReview help menu items don't open in a new tab

Status: RESOLVED FIXED

(MozReview Graveyard :: Review Board: User Interface, defect)

Description

[Māris Fogels [:mars] (please needinfo)]

The MozReview help menu in the upper-right corner of the UI opens it's items in the current tab.  This surprised me - I expected reference documentation like 'User Guide' and 'Mercurial for Mozillians' to open in new tabs, so I don't lose what I was doing on my Review Board page, and so I can reference both the app and docs pages at the same time.

This also surprised me because other webapps I have used open external reference documentation in new tabs.

Comment 1

[David Walsh :davidwalsh]

Attachment: MozReview: Open 'MozReview' header links in new window (Bug 1275305).

Review commit: https://reviewboard.mozilla.org/r/61066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61066/

Comment 2

[David Walsh :davidwalsh]

Comment on attachment 8765982 [details]
MozReview: Open 'MozReview' header links in new window (Bug 1275305).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61066/diff/1-2/

Comment 3

[David Walsh :davidwalsh]

https://reviewboard.mozilla.org/r/61066/#review57904

Sadly this is the best way to do this -- you cannot add `'target': 'blank'` to the item set for the `HeaderDropdownActionHook` :/

Comment 4

[:glob ✱]

Comment on attachment 8765982 [details]
MozReview: Open 'MozReview' header links in new window (Bug 1275305).

https://reviewboard.mozilla.org/r/61066/#review58048

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/35bb71e25f28
MozReview: Open 'MozReview' header links in new window . r=glob