Closed
Bug 1275358
Opened 8 years ago
Closed 8 years ago
Reword action extensions to include Firefox and Beta
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
fxios | 5.0+ | --- |
People
(Reporter: rfeeley, Assigned: jhugman)
References
Details
(Whiteboard: [needsstrings])
Attachments
(1 file)
195.11 KB,
image/png
|
Details |
When choosing to enable action extensions in iOS, labels "Send Tab" and "View Later" have no icons and therefore have no discoverability for Firefox users. To make matters worse, the beta version of Firefox adds a duplicate item. CURRENT: Send Tab Send Tab View Later View Later PROPOSED: Send Tab to Firefox Send Tab to Firefox β View Later in Firefox View Later in Firefox β SHORTER VERSION: Send to Firefox Send to Firefox β Later in Firefox Later in Firefox β
Updated•8 years ago
|
tracking-fxios:
--- → ?
Updated•8 years ago
|
Assignee: nobody → jhugman
Updated•8 years ago
|
Rank: 5
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
This should be relatively easy, _but_ we are not already localizing the View Later or Send To extensions. https://github.com/mozilla/firefox-ios/blob/master/Extensions/ViewLater/Info.plist#L8 sleroux: should I proceed?
Flags: needinfo?(sleroux)
Whiteboard: [needsstrings]
Comment 2•8 years ago
|
||
I'd say go for it since its just the titles and we branched yesterday so I can't imagine it would be difficult to rexport. :st3fan?
Flags: needinfo?(sleroux) → needinfo?(sarentz)
Assignee | ||
Comment 3•8 years ago
|
||
Here's the results of my investigation: 1. We can do string substitution in the Info.plist files. Currently, $(MOZ_BUNDLE_DISPLAY_NAME) is a handy variable for the name of the app. 2. None of our extensions have localized Info.plist files. Each of them require a InfoPlist.strings file. This is straightforward to do, and we should probably do this for each of the 3. It is not straightforward to do both. That is to say: it is not possible (out the box) to do string substitution in the InfoPlist.strings file. Doing both involves adding build steps, which at this late stage, and for this many users feels risky. My recommendation is thus: we close this bug and open another to localize the View Later and Send To extensions.
Status: ASSIGNED → NEW
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(rfeeley)
Reporter | ||
Comment 4•8 years ago
|
||
Sounds like a plan. James, will you file the bug?
Flags: needinfo?(rfeeley)
Assignee | ||
Comment 5•8 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=1277500
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Updated•8 years ago
|
Flags: needinfo?(sarentz)
You need to log in
before you can comment on or make changes to this bug.
Description
•