Closed Bug 1275381 Opened 3 years ago Closed 3 years ago

video doesn't play

Categories

(Core :: Audio/Video: Playback, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: tnikkel, Assigned: jya)

References

()

Details

(Keywords: compat)

Attachments

(1 file)

https://streamable.com/0449 doesn't play on Windows with Firefox. Works in Chrome (Windows and Mac). Works on Mac with Firefox.
The bug is present in at least 44, 46, and current nightly.
Jean-Yves - any idea why this video is broken?
Priority: -- → P1
if plays with ffmpeg and mac VT decoder.

If it doesn't play on windows it would be a WMF issue. will investigate.
Flags: needinfo?(jyavenard)
Assignee: nobody → jyavenard
Flags: needinfo?(jyavenard)
It's the audio decoder that somehow reports an error.
SetInputType returns: 0xc00d36b4 : The data specified for the media type is invalid, inconsistent, or not supported by this object.	HRESULT

As the WMF decoder fails to decode it, it falls back to using the GMP one (which I believe would be the Adobe one); and so the video plays fine here.
WMF is very strict with the AudioSpecificConfig passed on. The object type must be 2 and have the size of 2. So if those rules aren't followed we instead pass a simplistic AudioSpecificConfig.

Review commit: https://reviewboard.mozilla.org/r/56864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56864/
Attachment #8758610 - Flags: review?(cpearce)
Comment on attachment 8758610 [details]
MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish

https://reviewboard.mozilla.org/r/56864/#review53770
Attachment #8758610 - Flags: review?(cpearce) → review+
Comment on attachment 8758610 [details]
MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56864/diff/1-2/
Attachment #8758610 - Attachment description: MozReview Request: Bug 1275381: [aac] Rework invalid AudioSpecificConfig. r?cpearce → MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish
Attachment #8758610 - Flags: review?(dglastonbury)
https://reviewboard.mozilla.org/r/56864/#review53822

I've reworked the patch to narrow the time the code will be activated. We now attempt to detect when the ASC should be 2 bytes long, and if not truncate it.

The ASC of this file has a sync extension that the WMF aac decoder doesn't like
Attachment #8758610 - Flags: review?(dglastonbury) → review+
Comment on attachment 8758610 [details]
MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish

https://reviewboard.mozilla.org/r/56864/#review54250
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecdb77ae5681
[aac] Rework AudioSpecificConfig if extensions are present. r=cpearce,kamidphish,?kamidphish
https://hg.mozilla.org/mozilla-central/rev/ecdb77ae5681
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.