1275381 - video doesn't play

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Timothy Nikkel (:tnikkel)]

https://streamable.com/0449 doesn't play on Windows with Firefox. Works in Chrome (Windows and Mac). Works on Mac with Firefox.

Comment 1

[Timothy Nikkel (:tnikkel)]

The bug is present in at least 44, 46, and current nightly.

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Jean-Yves - any idea why this video is broken?

Comment 3

[Jean-Yves Avenard [:jya]]

if plays with ffmpeg and mac VT decoder.

If it doesn't play on windows it would be a WMF issue. will investigate.

Comment 4

[Jean-Yves Avenard [:jya]]

It's the audio decoder that somehow reports an error.

Comment 5

[Jean-Yves Avenard [:jya]]

SetInputType returns: 0xc00d36b4 : The data specified for the media type is invalid, inconsistent, or not supported by this object.	HRESULT

As the WMF decoder fails to decode it, it falls back to using the GMP one (which I believe would be the Adobe one); and so the video plays fine here.

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish

WMF is very strict with the AudioSpecificConfig passed on. The object type must be 2 and have the size of 2. So if those rules aren't followed we instead pass a simplistic AudioSpecificConfig.

Review commit: https://reviewboard.mozilla.org/r/56864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56864/

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8758610 [details]
MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish

https://reviewboard.mozilla.org/r/56864/#review53770

Comment 8

[Jean-Yves Avenard [:jya]]

Comment on attachment 8758610 [details]
MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56864/diff/1-2/

Comment 9

[Jean-Yves Avenard [:jya]]

https://reviewboard.mozilla.org/r/56864/#review53822

I've reworked the patch to narrow the time the code will be activated. We now attempt to detect when the ASC should be 2 bytes long, and if not truncate it.

The ASC of this file has a sync extension that the WMF aac decoder doesn't like

Comment 10

[u480271]

Comment on attachment 8758610 [details]
MozReview Request: Bug 1275381: [aac] Rework AudioSpecificConfig if extensions are present. r?cpearce,?kamidphish

https://reviewboard.mozilla.org/r/56864/#review54250

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecdb77ae5681
[aac] Rework AudioSpecificConfig if extensions are present. r=cpearce,kamidphish,?kamidphish

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ecdb77ae5681