Intermittent e10s PROCESS-CRASH | Main app process exited normally | application crashed [@ JS::Zone::~Zone()] after Assertion failure: typeDescrObjects.empty(), at /builds/slave/m-cen-m64-d-000000000000000000/build/src/js/src/gc/Zone.cpp:61

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript: GC
P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: philor, Assigned: jonco)

Tracking

(Blocks: 1 bug, {assertion, intermittent-failure})

unspecified
mozilla50
assertion, intermittent-failure
Points:
---

Firefox Tracking Flags

(e10s+, firefox50 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
https://treeherder.mozilla.org/logviewer.html#?job_id=3937992&repo=mozilla-central
https://treeherder.mozilla.org/logviewer.html#?job_id=9498026&repo=fx-team

Updated

2 years ago
Blocks: 984139
tracking-e10s: --- → +

Comment 1

2 years ago
8 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 5
* try: 2
* fx-team: 1

Platform breakdown:
* osx-10-10: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1275448&startday=2016-05-30&endday=2016-06-05&tree=all
(Assignee)

Comment 2

2 years ago
From the logs we're leaking a whole bunch of stuff at shutdown (see logs) which is also causing this assert to go off.

Comment 3

2 years ago
6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* try: 1
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1275448&startday=2016-06-06&endday=2016-06-12&tree=all
Intermittent test crash
Priority: -- → P3

Comment 5

a year ago
17 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 7
* fx-team: 5
* autoland: 5

Platform breakdown:
* android-4-3-armv7-api15: 12
* osx-10-10: 4
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1275448&startday=2016-07-04&endday=2016-07-10&tree=all
(Assignee)

Comment 6

a year ago
Created attachment 8773307 [details] [diff] [review]
bug1275448-dont-crash-on-leak

This doesn't fix the underlying problem which is that we sometimes leak, it just means that we don't crash due to an assertion failure in that case.

The assertion still runs if we don't leak which is most of the time.
Assignee: nobody → jcoppeard
Attachment #8773307 - Flags: review?(sphink)
Comment on attachment 8773307 [details] [diff] [review]
bug1275448-dont-crash-on-leak

Review of attachment 8773307 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +3599,5 @@
>  
>                  // We are about to delete the Zone; this will leave the Zone*
>                  // in the arena header dangling if there are any arenas
>                  // remaining at this point.
> +                mozilla::DebugOnly<bool> arenasEmpty = zone->arenas.checkEmptyArenaLists();

Can you name this allArenasEmpty?
Attachment #8773307 - Flags: review?(sphink) → review+
(Assignee)

Comment 8

a year ago
(In reply to Steve Fink [:sfink] [:s:] from comment #7)
> Can you name this allArenasEmpty?

I don't want to do this because it's not just a predicate but prints information about any cells that are still live (in debug builds).

Comment 9

a year ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9abfc5925a2
Don't crash on shutdown due to non-empty type descriptors set if we leak r=sfink
(In reply to Jon Coppeard (:jonco) from comment #8)
> (In reply to Steve Fink [:sfink] [:s:] from comment #7)
> > Can you name this allArenasEmpty?
> 
> I don't want to do this because it's not just a predicate but prints
> information about any cells that are still live (in debug builds).

I just meant the DebugOnly<bool> local variable, not the method name, which I'm fine with. But it's fine.
5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* mozilla-central: 2
* fx-team: 1

Platform breakdown:
* osx-10-10: 4
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1275448&startday=2016-07-18&endday=2016-07-24&tree=all
(Assignee)

Comment 12

a year ago
(In reply to Steve Fink [:sfink] [:s:] from comment #10)
Ah, sorry, I misunderstood your comment.

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9abfc5925a2
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.